evm: Fix empty instructions for WH endpoint #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djb15
force-pushed
the
fix-wormhole-endpoint-parsing
branch
from
e329050
to
ba4e39d
Compare
RahulMaganti47
approved these changes
Feb 24, 2024
djb15
force-pushed
the
fix-wormhole-endpoint-parsing
branch
2 times, most recently
from
76b7efe
to
50694ee
Compare
kcsongor
force-pushed
the
fix-wormhole-endpoint-parsing
branch
from
50694ee
to
5b0c88d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
transfer(uint256 amount, uint16 recipientChain, bytes32 recipient)variant always fails with the WH endpoint since the instruction payload is 0 bytes long by default when it isn't provided. This updates the parser to exit early and default to false if no instructions are provided.