-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solana: pay the original payers back #193
Conversation
01dd0da
to
ca12834
Compare
1c287ec
to
2746d80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest making one of these two changes:
- Either do not enforce
executor
to be the owner ofexecutor_token
- Or do not enforce
executor
to be equal toprepared_order_response.prepared_by
. Instead, add another field that will be linked to this account and to which the SOL from closed account will be returned.
Our requirement is simple, we just need SOL to be returned to a wallet that pays for tx fees and rent (across all transactions) and USDC returned to a token account which is not owned by this wallet.
solana/programs/matching-engine/src/processor/auction/settle/complete.rs
Outdated
Show resolved
Hide resolved
solana/programs/matching-engine/src/processor/auction/settle/complete.rs
Show resolved
Hide resolved
We have found another issue in
I think after changes made in this PR, |
Very good catch! How does this look? c6bd633 |
318e258
to
31871c8
Compare
31871c8
to
c9ac52c
Compare
prepared_by
toAuction
account to save original rent payer when placing the initial offerbeneficiary
to always beprepared_by
onPreparedOrderResponse
when settling a complete auctionbeneficiary
), who will have specified which token account to send the base fee to