Fix app rating upsert issue #1136
Merged
+97
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takaros999
temporarily deployed
to
development
GitHub Actions
Inactive
Takaros999
temporarily deployed
to
development
GitHub Actions
Inactive
Takaros999
temporarily deployed
to
development
GitHub Actions
Inactive
andy-t-wang
approved these changes
Jan 16, 2025
| FROM app_reviews | ||
| WHERE app_reviews.app_id = app.id | ||
| ), | ||
| rating_count = ( |
There was a problem hiding this comment.
Good catch we only need to update rating_count though. No need to do sum as well. Will make this operation slightly cheaper
Takaros999
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Description
This PR fixes an issue with app ratings and adds a migration script to recalculate app ratings.
Issue
Currently, we're using a rolling sum to update app ratings. We allow the user to upsert his review and apply the rating difference to the app's rating sum. The issue is that we're updating the rating count each time the user updates his review, this means that if multiple user decide to change their app rating they can affect the total app rating score, because the rating count will increase while app reviews stay the same.
Migration script
Added a migration script to recalculate app ratings.
Checklist