Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include freedesktop sdk TypeScript extension #988

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Include freedesktop sdk TypeScript extension #988

merged 3 commits into from
Oct 18, 2024

Conversation

sonnyp
Copy link
Contributor

@sonnyp sonnyp commented Oct 17, 2024

Closes #975

TypeScript is still disabled by default for now but it's just a gsetting.

@sonnyp sonnyp requested a review from vixalien October 17, 2024 20:58
Copy link
Contributor

@vixalien vixalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test the PR to see if it actually works but looks good for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but why even do you have the non-Devel manifest here 🤔 it probably should only exist in the flathub repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Occasional testing when they diverge.

The manifest in this repo is the source of truth for flathub. I copy it over to flathub when I release.

@sonnyp sonnyp merged commit 2057f39 into main Oct 18, 2024
1 check failed
@sonnyp sonnyp deleted the ts-youpi branch October 18, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaScript diagnostics for CI
2 participants