Revert "Remove Biome (#973)"

This reverts commit 6a1dd63.

build-aux/modules/biome.json

@@ -0,0 +1,21 @@
+{
+  "name": "biome",
+  "buildsystem": "simple",
+  "build-commands": ["chmod +x biome", "cp biome /app/bin/biome"],
+  "sources": [
+    {
+      "type": "file",
+      "dest-filename": "biome",
+      "only-arches": ["aarch64"],
+      "url": "https://github.com/biomejs/biome/releases/download/cli%2Fv1.8.3/biome-linux-arm64",
+      "sha256": "d134e89f6f4fc29d32c8101efb074969ac263ebdb0303e07039e3735002c6a2d"
+    },
+    {
+      "type": "file",
+      "dest-filename": "biome",
+      "only-arches": ["x86_64"],
+      "url": "https://github.com/biomejs/biome/releases/download/cli%2Fv1.8.3/biome-linux-x64",
+      "sha256": "5495f2f69edd94e9f26ed1adb9ed8023d7c143c3cc6f275f90abdded612217e4"
+    }
+  ]
+}

build-aux/re.sonny.Workbench.Devel.json

@@ -38,6 +38,7 @@
   ],
   "modules": [
     "modules/blueprint-compiler.json",
+    "modules/biome.json",
     "modules/gst-plugin-gtk4.json",
     "modules/vte.json",
     "modules/libshumate.json",

build-aux/re.sonny.Workbench.json

@@ -38,6 +38,7 @@
   ],
   "modules": [
     "modules/blueprint-compiler.json",
+    "modules/biome.json",
     "modules/gst-plugin-gtk4.json",
     "modules/vte.json",
     "modules/libshumate.json",

data/app.metainfo.xml

@@ -85,7 +85,7 @@
         </ul>
         <p>Dependencies:</p>
         <ul>
-          <li>Replace Biome with TypeScript Language Server</li>
+          <li>Update Biome to 1.8.3</li>
           <li>Update gst-plugin-gtk4 to 1.12.7</li>
           <li>Update libshumate to 1.3</li>
           <li>Update Blueprint to 0.14.0</li>

src/application.js

@@ -64,7 +64,23 @@ application.connect("open", (_self, files, hint) => {
   load().catch(console.error);
 });
 
+let proc_biome;
+
 application.connect("startup", () => {
+  // biome lsp-proxy starts a background server
+  // it does not get stopped and leaves a process hanging
+  // so manage it manually instead
+  // See https://github.com/workbenchdev/Workbench/issues/828
+  const subprocess_launcher = Gio.SubprocessLauncher.new(
+    Gio.SubprocessFlags.STDERR_SILENCE,
+  );
+  proc_biome = subprocess_launcher.spawnv([
+    "biome",
+    "__run_server",
+    "--config-path",
+    pkg.pkgdatadir,
+  ]);
+
   Library({
     application,
   });
@@ -74,6 +90,10 @@ application.connect("startup", () => {
   restoreSessions().catch(console.error);
 });
 
+application.connect("shutdown", () => {
+  proc_biome?.force_exit();
+});
+
 application.connect("activate", () => {
   if (application.is_remote) {
     bootstrap().catch(console.error);

src/langs/css/CssDocument.js

@@ -25,7 +25,7 @@ export class CssDocument extends Document {
       },
     });
 
-    // GTKCssLanguageServer doesn't support diff - it just returns one edit
+    // Biome doesn't support diff - it just returns one edit
     // we don't want to loose the cursor position so we use this
     const state = this.code_view.saveState();
     applyTextEdits(text_edits, this.buffer);

src/langs/javascript/JavaScriptDocument.js

@@ -26,6 +26,10 @@ export class JavaScriptDocument extends Document {
       },
     });
 
+    // Biome doesn't support diff - it just returns one edit
+    // we don't want to loose the cursor position so we use this
+    const state = this.code_view.saveState();
     applyTextEdits(text_edits, this.buffer);
+    await this.code_view.restoreState(state);
   }
 }

src/langs/javascript/biome.json

@@ -0,0 +1,19 @@
+{
+  "$schema": "https://biomejs.dev/schemas/1.3.3/schema.json",
+  "javascript": {
+    "globals": ["workbench"]
+  },
+  "formatter": {
+    "indentStyle": "space",
+    "indentWidth": 2
+  },
+  "linter": {
+    "rules": {
+      "recommended": false,
+      "correctness": {
+        "noUndeclaredVariables": "error",
+        "noUnusedVariables": "warn"
+      }
+    }
+  }
+}

src/meson.build

@@ -47,6 +47,7 @@ configure_file(
 )
 
 install_data('langs/vala/workbench.vala', install_dir: pkgdatadir)
+install_data('langs/javascript/biome.json', install_dir: pkgdatadir)
 install_data('project-readme.md', install_dir: pkgdatadir)
 subdir('libworkbench')
 subdir('Previewer')