[4단계 - JDBC 라이브러리 구현하기] 포케(이무송) 미션 제출합니다. #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/com/techcourse/service/UserService.java # app/src/test/java/com/techcourse/service/UserServiceTest.java
jcoding-play
requested changes
Oct 21, 2024
| } | ||
|
|
||
| @Override | ||
| @Transactional |
There was a problem hiding this comment.
TxUserService를 통해 @Transactional 동작 원리를 구현했는데, @Transactional 어노테이션을 넣는게 맞나요?? 😀
There was a problem hiding this comment.
이부분 놓쳤네요 😅 반영 완료했습니다!!
There was a problem hiding this comment.
|
|
||
| public abstract class TransactionSynchronizationManager { | ||
|
|
||
| private static final ThreadLocal<Map<DataSource, Connection>> resources = new ThreadLocal<>(); | ||
| private static final ThreadLocal<Map<DataSource, Connection>> resources = ThreadLocal.withInitial(HashMap::new); |
| public static void releaseConnection(Connection connection, DataSource dataSource) { | ||
| public static void releaseConnection(DataSource dataSource) { |
There was a problem hiding this comment.
jdbctemplate에서 execute메서드를 실행할 때 트렌젝션의 유무의 따라 커넥션을 닫는 여부를 결정해야 하는데,
트렌젝션이 설정되어 있으면 롤백을 위해 커넥션을 닫으면 안되서 분리하게 되었습니다..!
Comment on lines
32
to
35
| Connection connection = TransactionSynchronizationManager.getResource(dataSource); | ||
| if (connection.getAutoCommit()) { | ||
| connection.close(); | ||
| } |
There was a problem hiding this comment.
만약 반환받은 connection이 null이라면 예외가 발생할 것 같아요~!
There was a problem hiding this comment.
해당부분 반영 했습니다~~
|
안녕하세요 뽀로로~ 테스트가 깨져있었군요..! 해당 오류는 TransactionSynchronizationManager에서 자원을 해제하지 않아서 발생하고 있었던 문제여서 아래의 커밋으로 해결했습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 뽀로로!
4단계 미션 제출합니다.
아직 학습테스트 부분은 수행하지 않았어서 리뷰 후에 업로드 하도록 하겠습니다..!4단계 마지막! 잘 부탁드려요 👋
학습테스트 반영했습니다 😄