[4단계 - JDBC 라이브러리 구현하기] 도비(김도엽) 미션 제출합니다. #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tackyu
requested changes
Oct 15, 2024
Comment on lines
+45
to
+46
| TransactionSynchronizationManager.unbindResource(dataSource); | ||
| } |
There was a problem hiding this comment.
unbindResource(dataSource)가
releaseConnection 안에서 수행되는 것은 어떻게 생각하세요??
There was a problem hiding this comment.
unbindedResource는 단순히 바인딩을 끊는 용도로도 사용되어야된다고 생각합니다. 같은 Transaction을 사용하다가도, 사용하지 않을 수도 있어야하니까요 :>
Comment on lines
+39
to
+40
| try { | ||
| conn.rollback(); |
There was a problem hiding this comment.
Transaction 안에서의 sql 쿼리가 실패하면 rollback 해야하지 않을까요?
There was a problem hiding this comment.
try (Connection conn = DataSourceUtils.getConnection(dataSource)) {
conn.setAutoCommit(false);
User user = updateUserPassword(conn, id, newPassword);
userHistoryDao.log(conn, new UserHistory(user, createBy));
conn.commit();
} catch (SQLException e) {
throw new DataAccessException("Failed to change password", e);
}이전 단계에서 try-catch로 처리 하셔서 궁금했습니다!
Comment on lines
12
to
13
| void changePassword(final long id, final String newPassword, final String createdBy) throws SQLException; | ||
| } |
Comment on lines
+89
to
+91
| public DataSource getDataSource() { | ||
| return dataSource; | ||
| } |
There was a problem hiding this comment.
dataSource를 반환하게끔 설계하신 이유가 궁금합니다
update와 같은 메서드에서 직접 커넥션을 가져와, 메서드 오버로딩을 없애는 것에 대해 도비의 의견이 궁금하네요!
There was a problem hiding this comment.
해당 jdbcTemplate에서 datasource를 가져와야 Util에서 map으로 존재하는 같은 connection을 찾아 들고 올 수 있게 했어야했습니다!
여러 datasource가 존재할 때가 있을 수 있으니까요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 뽀오오오온드
벌써 마지막 리뷰 요청이군요!
이번 리뷰에서는 마지막 리뷰인만큼 여유를 가지고 여러 얘기 나눠보면 좋을 것 같습니다 :>
리뷰 잘부탁드린다구요😘😘