New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1.1/AN-REFACTOR] 포켓몬 상세, 인트로 부분 koin 적용 #406

Closed

sh1mj1 wants to merge 0 commits into an/develop from an/refactor/pokemon-detail-koin-migration

Contributor

sh1mj1 commented Oct 23, 2024 •

edited

Loading

closed [1.1.1/AN-REFACTOR] 포켓몬 상세, 인트로 부분 koin 적용 #374

작업 영상

그런 건 없어요

작업한 내용

포켓몬 상세 koin 마이그레이션
Intro ViewModel koin 마이그레이션

PR 포인트

포켓몬 상세에서 배틀 도우미로 가는 floating 버튼 추가 : 이거 리버트 되어서 이거 이후에 머지 되어야 합니다.
포켓몬 상세의 프래그먼트가 쓰던 onResume 메서드 내부의 onRequestLayout 삭제
테스트 추가, 더 이상 사용하지 않는 팩토리 메서드들 삭제

🚀Next Feature

sh1mj1 changed the title ~~[1.1.1/AN-REFACTOR] 포켓몬 상세 부분 koin 적용~~ [1.1.1/AN-REFACTOR] 포켓몬 상세, 인트로 부분 koin 적용

sh1mj1 self-assigned this

sh1mj1 requested review from JoYehyun99, murjune and kkosang

October 23, 2024 15:01

sh1mj1 added v1.1.1 🏷️ AN_REFACTOR ✍️ labels

sh1mj1 closed this

sh1mj1 force-pushed the an/refactor/pokemon-detail-koin-migration branch from eff9ca1 to 1aba612 Compare

October 23, 2024 15:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AN_REFACTOR ✍️ v1.1.1 🏷️