Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1.1/AN-UI] 홈 화면 반응형 UI 구현하기 #383

Merged
merged 6 commits into from
Oct 23, 2024
Merged

[1.1.1/AN-UI] 홈 화면 반응형 UI 구현하기 #383

merged 6 commits into from
Oct 23, 2024

Conversation

kkosang
Copy link
Contributor

@kkosang kkosang commented Oct 22, 2024

작업 영상

an.ui._.webm
an.ui._.webm

작업한 내용

  • 홈 화면 가로모드 수정 -> 배틀구도와 바이옴이 메뉴에 없었습니다 !
  • sw600dp 대응하여 태블릿 가로,세로 화면 대응

PR 포인트

  • 태블릿 화면에서 영상이 뒤집어져서 나오는데, 노트북을 돌려서 보시면 편하게 보실 수 있답니다 ㅎㅎ 😅😅

🚀Next Feature

  • 빠르게 특성 대응할게유

JoYehyun99
JoYehyun99 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@JoYehyun99 JoYehyun99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳 👍
개인적으로 태블릿 대응일 경우, 아이템 크기를 줄여서 스크롤이 최대한 없도록 해도 좋을 것 같다는 생각입니다 ~ 🙃

murjune
murjune approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@murjune murjune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꼬갓! 바로 그겁니다

murjune
murjune approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@murjune murjune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 LGTM ⭐️

android/app/src/main/res/values-sw600dp/dimens.xml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dimension까지 반영 괴물...

sh1mj1

This comment was marked as duplicate.

Sign in to view

sh1mj1
sh1mj1 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@sh1mj1 sh1mj1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!~

@kkosang kkosang merged commit 1b08976 into an/develop Oct 23, 2024
3 checks passed
@kkosang kkosang deleted the an/ui/home_responsive_ui branch October 23, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh1mj1 sh1mj1 sh1mj1 approved these changes

@murjune murjune murjune approved these changes

@JoYehyun99 JoYehyun99 JoYehyun99 approved these changes

Assignees

@kkosang kkosang

Labels
AN_UI 🎨 안드 UI 작업 v1.1.1 🏷️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkosang @JoYehyun99 @murjune @sh1mj1