[FE] 생성된 약속 링크를 공유하는 페이지 UI, 클립보드 복사 기능 구현 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 2f1088a. ♻️ This comment has been updated with latest results. |
|
리뷰하기전에 일단 너무 귀엽다 |
Largopie
approved these changes
Jul 25, 2024
| justify-content: center; | ||
|
|
||
| width: 100%; | ||
| height: calc(100vh - 6rem); |
There was a problem hiding this comment.
[P3]
사소하지만, 헤더 외 나머지 높이를 적용하고 싶을 때 부모 태그에 flex 적용 후 해당 컴포넌트에 flex: 1;속성을 사용하게 되면 나머지가 채워지게 됩니다! 참고차 남겼습니다~!
There was a problem hiding this comment.
오 꿀팁 감사합니다!! flex: 1 사용하니까 훨씬 편하네요!
사용 시도하고 잘 적용되는 것도 확인했습니다.
다만, 변경할 때 상위 GlobalLayout 컴포넌트의 s_globalContainer에서 display: flex;를 적용해 줘야해서
현재 낙타와 해리가 작업 중인 스타일에 영향을 줄 것 같습니다🥹😭
추후 한 번에 수정하도록 하겠습니다!
There was a problem hiding this comment.
제가 제안한 네이밍이 반영되었네요!🥳🥳🥳
감사합니다 🐫
| @@ -0,0 +1,8 @@ | |||
| export const copyToClipboard = async (text: string) => { | |||
There was a problem hiding this comment.
[Q]
여기 함수 이름을 어떻게 통일 시키면 좋을까요? 이것도 얘기를 나누어보면 좋겠네요!
export const a = () => {}
export function a() {}
hwinkr
approved these changes
Jul 25, 2024
Comment on lines
+21
to
+22
| {/* TODO: '${약속 명} 약속을 만들었어요 :)'로 변경 논의 후 적용 (@Yoonkyoungme) */} | ||
| <div css={s_description}>약속을 만들었어요 :)</div> |
Yoonkyoungme
force-pushed
the
feat/74-share-meeting-link
branch
from
8afcad8
to
2f1088a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
copyToClipboard를 추가 (utils/clipboard.ts)특이 사항
→ 복사 되었다는 것을 명시적으로 표현하기 위해 일시적으로 alert를 띄우게 해두었습니다.
→ 복사할 텍스트는 임의로 상수 데이터로 설정하였습니다. 추후
prop data또는useLocation에서 보내주는 값으로 교체해야 할 것 같아요.리뷰 요구사항 (선택)