Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 약속 공유 링크 상수 경로 수정 #434

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Largopie
Copy link
Contributor

관련 이슈

작업 내용

링크가 https://가 아닌 https:/로 경로가 설정되어 경로를 인식하지 못하는 문제가 있었습니다.
이를 해결하기 위해 origin 경로 자체를 복사하도록 상수를 수정했습니다.

// 수정 전
const LINK = `${window.location.protocol}/${window.location.host}/meeting/${uuid}`;

// 수정 후
const LINK = `${window.location.origin}/meeting/${uuid}`;

특이 사항

리뷰 요구사항 (선택)

@Largopie Largopie added the 🛠️ 픽스 버그를 해결했어요 :) label Nov 12, 2024
@Largopie Largopie added this to the 6차(최종) 데모데이 milestone Nov 12, 2024
@Largopie Largopie self-assigned this Nov 12, 2024
Copy link

Test Results

35 tests   32 ✅  21s ⏱️
 4 suites   0 💤
 1 files     3 ❌

For more details on these failures, see this check.

Results for commit 1f4c200.

Copy link
Contributor

@Yoonkyoungme Yoonkyoungme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿👍🏻
현재 URI 경로에 포함된 /meeting/ 부분은 다음 단계에서 제외하는 URI 리팩토링이 필요할 것 같네요!

🚨테스트 통과 못 하는 문제 확인해 주세요🚨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ 픽스 버그를 해결했어요 :)
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants