[FE] BottomFixedButton 버그 수정 #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results9 tests 9 ✅ 11s ⏱️ Results for commit 5088a20. |
hwinkr
approved these changes
Oct 6, 2024
Yoonkyoungme
approved these changes
Oct 7, 2024
| @@ -10,7 +10,6 @@ export const s_container = css` | |||
| export const s_relativeContainer = css` | |||
| position: relative; | |||
| flex: 1; | |||
| max-height: fit-content; | |||
There was a problem hiding this comment.
[Q]
어떤 문제가 발생해서 max-height: fit-content를 삭제하였는지 궁금합니다!
There was a problem hiding this comment.
현재 s_relativeContainer의 부모 요소는 flex로 이루어져있습니다. 따라서 fit-content를 지정하더라도 flex요소 내에서 채우는 것이라 사실상 의미가 없다고 보시면 될 것 같습니다.
또한 max-height가 정해짐으로써 설정했던 flex:1은 max-height 기반으로 적용이 되는 것으로 예상되었습니다.
그래서 max-height를 제거하는 쪽으로 결정했습니다!
ehBeak
pushed a commit
that referenced
this pull request
Oct 11, 2024
* rename: meetingFrame 렌더 함수 네이밍 수정 * refactor: gap 속성 추가 및 시간 선택 테이블 max-height 제거, MSW 주석 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
특이 사항
없어용
리뷰 요구사항 (선택)