[FE] 비밀번호 입력 간소화 및 모바일 숫자 키패드를 적용 #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results5 tests 5 ✅ 3s ⏱️ Results for commit 4df0b5e. ♻️ This comment has been updated with latest results. |
hwinkr
approved these changes
Sep 4, 2024
Comment on lines
+83
to
+84
| inputMode="numeric" | ||
| pattern="[0-9]*" |
There was a problem hiding this comment.
[C]
오, 이렇게 하면 ios 디바이스에서도 숫자 키패드를 띄울 수 있군요! 하나 배워갑니다
TERN으로 변경하여 정규표현식 사용 - 각 필드의 유효성 검사 규칙을 정규표현식으로 단순화 - 비밀번호 규칙을 4자리 숫자로 변경 - 비밀번호 input type을 number로 설정
Yoonkyoungme
force-pushed
the
feat/339-simplify-password-and-mobile-keypad
branch
from
5802afa
to
4df0b5e
Compare
Yoonkyoungme
deleted the
feat/339-simplify-password-and-mobile-keypad
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
1. 입력 필드 유효성 검사 규칙 개선 및 단순화
2. 모바일 숫자 키패드 적용
inputMode="numeric"과pattern="[0-9]*"속성을 추가하여 iOS 기기에서 숫자 전용 키패드가 표시되도록 개선)참고 자료
작업 현황 정리 노션 링크
특이 사항
비밀번호 입력이 4자리 숫자로 변경되고 모바일 키패드 입력이 도입됨에 따라
PasswordInput 컴포넌트(비밀번호 숨기기/표시 기능이 포함된 컴포넌트)는 현재 사용되지 않고 있습니다.그러나 추후에 필요할 수 있으므로 컴포넌트는 삭제하지 않고 남겨두었습니다.
리뷰 요구사항 (선택)