Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 추천 약속 리스트를 선택할 때 key 값을 startDate + index 대신 rank로 변경 #318

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

Yoonkyoungme
Copy link
Contributor

관련 이슈

작업 내용

rank 값을 key로 사용하여 동일 key가 생기는 문제 해결

추천 약속 리스트에서 중복 선택 문제를 해결하기 위해, 서버 측에서 '추천 일정 조회' 응답에 rank 데이터를 추가하여 전송합니다.
이 rank 값을 key로 사용하여 중복 문제를 방지하였습니다.
기존에는 key 값을 startDate + index로 설정하였는데, 현재 rank로 변경하였습니다.

특이 사항

리뷰 요구사항 (선택)

@Yoonkyoungme Yoonkyoungme added 🐈 프론트엔드 프론트엔드 관련 이슈에요 :) 🛠️ 픽스 버그를 해결했어요 :) labels Aug 22, 2024
@Yoonkyoungme Yoonkyoungme added this to the 4차 데모데이 milestone Aug 22, 2024
@Yoonkyoungme Yoonkyoungme self-assigned this Aug 22, 2024
Copy link

github-actions bot commented Aug 22, 2024

Test Results

4 tests   4 ✅  3s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 8b5f6c9.

♻️ This comment has been updated with latest results.

Copy link
Member

@hw0603 hw0603 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@hwinkr hwinkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

페드로 교수님이 만들어주신 rank가 드디어 도착했군요!

- pages/MeetingConfirmPage/components/MeetingTimeOptions.tsx → pages/MeetingConfirmPage/components/MeetingTimeOptions/index.tsx
@Yoonkyoungme Yoonkyoungme force-pushed the fix/294-meeting-recommend-map-key branch from e6f0974 to 8b5f6c9 Compare August 23, 2024 01:03
Copy link
Contributor

@seunghye218 seunghye218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Yoonkyoungme Yoonkyoungme merged commit 729b96e into develop Aug 23, 2024
7 checks passed
@Yoonkyoungme Yoonkyoungme deleted the fix/294-meeting-recommend-map-key branch August 23, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐈 프론트엔드 프론트엔드 관련 이슈에요 :) 🛠️ 픽스 버그를 해결했어요 :)
Projects
Status: Done
4 participants