Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] 쿠키 설정 변경 #363

Merged
merged 15 commits into from
Oct 24, 2024
Merged

[FIX] 쿠키 설정 변경 #363

merged 15 commits into from
Oct 24, 2024

Conversation

jhon3242
Copy link
Member

Issue Number

close #357

As-Is

  • 프론트엔드에서 쿠키를 헤더에 담아서 요청을 보내려면 SameSite설정을 변경해야한다.
  • 멤버 정보를 조회하는 API가 rejoin이여서 혼란이 옴

To-Be

  • SameSite설정을 변경
  • rejoin 에서 member 로 URI 변경

Check List

  • 테스트가 전부 통과되었나요?
  • 모든 commit이 push 되었나요?
  • merge할 branch를 확인했나요?
  • Assignee를 지정했나요?
  • Label을 지정했나요?

Test Screenshot

image

(Optional) Additional Description

RoomMemberResponse는 RoomJoinReponse와 필드가 동일하지만 서로 응답하고자 하는바가 다르다고 생각하여 RoomMemberResponse를 추가했습니다.

@jhon3242 jhon3242 added 🛠 fix 버그 🍃 BE back end labels Oct 22, 2024
@jhon3242 jhon3242 self-assigned this Oct 22, 2024
leeseongsil
leeseongsil approved these changes Oct 24, 2024
Copy link
Contributor

@leegwichan leegwichan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link
Member

@GIVEN53 GIVEN53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋네요 므쨍이 ><

.allowedMethods(
HttpMethod.GET.name(), HttpMethod.POST.name(), HttpMethod.PATCH.name(), HttpMethod.DELETE.name()
)
.allowCredentials(true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jhon3242 jhon3242 merged commit e11b555 into develop Oct 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍃 BE back end 🛠 fix 버그
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FIX] 쿠키 설정 변경
4 participants