[REFACTOR] 방 설정 모달 접근성 개선 및 제한 시간 추가 반영 #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
novice0840
approved these changes
Oct 21, 2024
| @@ -16,64 +16,80 @@ import ArrowUp from '@/assets/images/arrowUp.svg'; | |||
| interface DropdownProps<T> { | |||
| text: string; | |||
| optionList: T[]; | |||
| handleClick: (e: React.MouseEvent<HTMLButtonElement>) => void; | |||
| handleClickOption: (e: React.MouseEvent<HTMLButtonElement, MouseEvent>) => void; | |||
There was a problem hiding this comment.
💭 질문 💭
이벤트 안에 또 이벤트가 있는 이유가 있나요?
There was a problem hiding this comment.
동일한 이름을 가진 MouseEvent 타입인데 다릅니다 !! 하나는 React의 Synthetic Event 타입, 다른 하나는 브라우저의 네이티브 이벤트 타입입니다 !!! 생략할 수 있는데 그러면 기본적으로 MouseEvent입니다. 명시적으로 작성했는데, 통일해서 생략하여 수정하도록 하겠습니다. ^. ^
- 통일성있게 사용하기 위해 기본값을 명시하지 않고 생략 #352
|
오프라인 코드 리뷰 후 변경 사항 반영하여 머지합니다 ✨🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#352
As-Is
개선 전
default.mov
문제점
카테고리 선택 목록
라운드, 제한 시간
To-Be
개선 후
default.mov
선택 목록
라운드, 제한 시간
Check List
Test Screenshot
(Optional) Additional Description
해당 자료들을 참고하였습니다 ✨
https://nuli.navercorp.com/community/article/1133219
https://www.w3.org/WAI/ARIA/apg/patterns/combobox/examples/combobox-select-only/
🌸 Storybook 배포 주소