[FEAT] 스크린 리더기 focus 개선 #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
rbgksqkr
approved these changes
Oct 21, 2024
| const handleClick = () => { | ||
| onConfirm && onConfirm(); | ||
| onClose(); | ||
| }; | ||
|
|
||
| return ( | ||
| <Modal isOpen={isOpen} onClose={onClose}> | ||
| <Modal isOpen={isOpen} onClose={onClose} closeRef={closeRef}> |
There was a problem hiding this comment.
💭 질문 💭
Button에는 ref로 적용했는데, Modal에서는 forwardRef를 적용하지 않은 이유가 궁금합니다!
| closeRef, | ||
| position = 'center', | ||
| ...restProps | ||
| }: ModalProps) => { |
| const goToBack = () => { | ||
| navigate(-1); | ||
| }; | ||
|
|
||
| return ( | ||
| <header css={headerLayout()}> | ||
| <header css={headerLayout()} tabIndex={0} ref={focusRef}> |
There was a problem hiding this comment.
💭 질문 💭
tabIndex=0 을 한 이유가 무엇인가요?
useon
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#335
As-Is
Modal 뒤에서만 이동함
To-Be
header-focus.mp4
modal-focus.mp4
modal-close.mp4
Check List
(Optional) Additional Description
scroll을 막는 hook이 있었는데 서비스에서 애초에 scroll을 막기 때문에 사용하지 않으므로 제거함
저번 PR에서 소리가 잘 들리지 않는 다는 피드백이 있어 이번에는 리더기 볼륨을 최대로 키웠습니다.
🌸 Storybook 배포 주소
🌸 Storybook 배포 주소