Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] 대기방 및 닉네임 화면 성능 개선 #295

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

novice0840
Copy link
Contributor

@novice0840 novice0840 commented Sep 25, 2024

Issue Number

#291

As-Is

대기방 및 닉네임 화면에서 성능 지표가 낮게 나오는 상황이라 성능 개선의 필요성을 느낌

To-Be

  • lazy loading / code splitting <- 이미 다른 PR에서 구현됨
  • font 최적화 <- 이미 PR 구현됨
  • Image 확장자 변경

Check List

  • 테스트가 전부 통과되었나요?
  • 모든 commit이 push 되었나요?
  • merge할 branch를 확인했나요?
  • Assignee를 지정했나요?
  • Label을 지정했나요?

Test Screenshot

개선 전
image

개선 후
image

평균적으로 이미지 크기가 60-70% 줄어든 것을 확인할 수 있음

(Optional) Additional Description

🌸 Storybook 배포 주소

https://woowacourse-teams.github.io/2024-ddangkong/storybook/

@novice0840 novice0840 linked an issue Sep 25, 2024 that may be closed by this pull request
3 tasks
@novice0840 novice0840 changed the title Refactor/#291 [REFACTOR] 대기방 및 닉네임 화면 성능 개선 Sep 26, 2024
@novice0840 novice0840 requested review from leegwichan, rbgksqkr and useon and removed request for leegwichan, rbgksqkr and useon September 26, 2024 01:01
@novice0840 novice0840 self-assigned this Sep 26, 2024
@novice0840 novice0840 added ♻️ refactor 리팩토링 ✨ feat 기능 추가 🫧 FE front end labels Sep 26, 2024
@novice0840 novice0840 added this to the FE Sprint5 milestone Sep 26, 2024
Copy link
Contributor

@rbgksqkr rbgksqkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 이미지 용량만 줄여도 개선이 많이 되더라구요! PR 개선 전이랑 개선 후랑 이미지가 바뀐 것 같아요~ 성능 개선 PR 이다보니 lighthouse도 PR에 개선전 개선후를 추가하면 좋을 것 같아용 일단 approve 하겠습니다:)

@novice0840 novice0840 added the 🔥 Emergency 긴급 처리(2명 리뷰 머지 PR) label Sep 26, 2024
@novice0840 novice0840 merged commit ad2d0e7 into develop Sep 26, 2024
2 checks passed
@novice0840 novice0840 deleted the refactor/#291 branch September 26, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Emergency 긴급 처리(2명 리뷰 머지 PR) 🫧 FE front end ✨ feat 기능 추가 ♻️ refactor 리팩토링
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 대기방 및 닉네임 화면 성능 개선
2 participants