템플릿 검색시 엔터를 눌러야 검색되도록 변경 #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hain-tain
requested review from
Jaymyong66
and removed request for
vi-wolhwa
…de-zap into refactor/899-remove-debounce-keyword
Jaymyong66
reviewed
Nov 15, 2024
| @@ -119,7 +124,7 @@ const MyTemplatePage = () => { | |||
| {!isTemplateListLoading && ( | |||
| <TemplateListSection | |||
| templateList={templateList} | |||
| isSearching={keyword !== ''} | |||
| isSearching={keyword !== '' || keyword !== searchKeyword} | |||
There was a problem hiding this comment.
keyword와 searchKeyword의 변수명 의미가 모호한거 같아요!
There was a problem hiding this comment.
keyword=>inputKeyword, searchKeyword=>searchedKeyword으로 변경하였습니다!
Jaymyong66
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
📍주요 변경 사항
🎸기타
🍗 PR 첫 리뷰 마감 기한
11/15