[FE] 인기 토픽 배너 수정 및 url 로 필터 정보 저장하도록 변경 #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(SourceCodeViewer): overflow: scroll 추가 * feat(src): HOT_TOPIC에 배경 사진 및 설명 추가 * refactor(TemplatePage): 사용하지 않는 스타일드컴포넌트 제거 * feat(HotTopicCarousel): 인기 토픽 캐로셀에 설명 추가 * refactor(Carousel): key 중복 제거 * design(Carousel): 캐로셀 선택시 border처리를 위한 마진 추가 * refactor(src): url 에서 조건 가져오도록 변경 * chore: generator 주석처리
Hain-tain
requested review from
zangsu,
zeus6768,
kyum-q,
HoeSeong123,
vi-wolhwa and
Jaymyong66
Jaymyong66
approved these changes
Oct 23, 2024
kyum-q
approved these changes
Oct 23, 2024
zangsu
approved these changes
Oct 23, 2024
HoeSeong123
approved these changes
Oct 23, 2024
jminkkk
approved these changes
Oct 23, 2024
Jaymyong66
approved these changes
Oct 23, 2024
zeus6768
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
close #이슈번호
📍주요 변경 사항
refactor(SourceCodeViewer): overflow: scroll 추가
feat(src): HOT_TOPIC에 배경 사진 및 설명 추가
refactor(TemplatePage): 사용하지 않는 스타일드컴포넌트 제거
feat(HotTopicCarousel): 인기 토픽 캐로셀에 설명 추가
refactor(Carousel): key 중복 제거
design(Carousel): 캐로셀 선택시 border처리를 위한 마진 추가
refactor(src): url 에서 조건 가져오도록 변경
chore: generator 주석처리
🎸기타
🍗 PR 첫 리뷰 마감 기한
00/00 00:00