Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-router-dom의 basename 설정, api filedName 수정 #130

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

Hain-tain
Copy link
Contributor

@Hain-tain Hain-tain commented Jul 24, 2024

⚡️ 관련 이슈

close #124

📍주요 변경 사항

1. react-router-dom의 basename 설정

2. contentSummary => thumbnailContent 로 필드명 변경

3. tsc 타입 체킹 추가

4. npm run start => npm run dev 로 명령어 변경

🎸기타

@Hain-tain Hain-tain self-assigned this Jul 24, 2024
@Hain-tain Hain-tain added feature 기능 추가 FE 프론트엔드 zap 리뷰 우선순위가 높은 사항 labels Jul 24, 2024
@Hain-tain Hain-tain added this to the 2차 스프린트 🐣 milestone Jul 24, 2024
Copy link
Contributor

@Jaymyong66 Jaymyong66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vi-wolhwa vi-wolhwa merged commit 41aa239 into woowacourse-teams:dev/fe Jul 24, 2024
1 check passed
@Hain-tain Hain-tain deleted the feat/router_basename branch July 24, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE 프론트엔드 feature 기능 추가 zap 리뷰 우선순위가 높은 사항
Projects
Status: Weekend Done
Development

Successfully merging this pull request may close these issues.

3 participants