Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

프론트엔드 CI 설정 (github actions) #105

Merged
merged 1 commit into from
Jul 23, 2024
Merged

프론트엔드 CI 설정 (github actions) #105

merged 1 commit into from
Jul 23, 2024

Conversation

Jaymyong66
Copy link
Contributor

⚡️ 관련 이슈

close #90

📍주요 변경 사항

  1. CI 파일 업로드
  • frontend 폴더에서 npm install 후 npm test

🎸기타

  1. node 버전을 20으로 맞추었습니다. github actions에서 다음과 같은 warning을 줍니다.
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

@Jaymyong66 Jaymyong66 added feature 기능 추가 FE 프론트엔드 labels Jul 23, 2024
@Jaymyong66 Jaymyong66 added this to the 2차 스프린트 🐣 milestone Jul 23, 2024
@Jaymyong66 Jaymyong66 self-assigned this Jul 23, 2024
Hain-tain
Hain-tain approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@Hain-tain Hain-tain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿굿 LGTM 👍

@vi-wolhwa
Copy link
Contributor

LGTV~ 굿굿

@vi-wolhwa vi-wolhwa merged commit 9d676bc into woowacourse-teams:dev/fe Jul 23, 2024
1 check passed
@Jaymyong66 Jaymyong66 deleted the feat/ci_setting branch August 15, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hain-tain Hain-tain Hain-tain approved these changes

@vi-wolhwa vi-wolhwa vi-wolhwa approved these changes

Assignees

@Jaymyong66 Jaymyong66

Labels
FE 프론트엔드 feature 기능 추가
Projects
2024-code-zap
Status: Weekend Done
Milestone
2차 스프린트 🐣
Development

Successfully merging this pull request may close these issues.
3 participants
@Jaymyong66 @vi-wolhwa @Hain-tain