Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 공모 상세 페이지 진입 시 로딩이 된 후에 화면을 보여주도록 수정 #609

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

Namyunsuk
Copy link
Contributor

📌 관련 이슈

close #544

✨ 작업 내용

  • 로딩 상태를 추가하여 로딩이 완료 된 경우 공모 상세 페이지를 보여주도록 하였습니다.
  • facebook의 skeleton ui라이브러리를 사용하였습니다.
  • 의존성 추가해주었습니다.
    // Skeleton-UI
    implementation(libs.shimmer)

📚 기타

Before

KakaoTalk_Video_2024-10-21-22-04-03.mp4

After

[deleay 3초]

KakaoTalk_Video_2024-10-21-22-05-02.mp4

[delay X]

KakaoTalk_Video_2024-10-21-22-05-32.mp4

@Namyunsuk Namyunsuk changed the title fix: 공모 상세 페이지 진입 시 로딩이 된 후에 화면을 보여주도록 수정 refactor: 공모 상세 페이지 진입 시 로딩이 된 후에 화면을 보여주도록 수정 Oct 21, 2024
Copy link
Contributor

@songpink songpink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 시머 좋네요 ㅎㅎ

Comment on lines +173 to +174
// Skeleton-UI
implementation(libs.shimmer)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 시머~~

Copy link
Contributor

@chaehyuns chaehyuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

시머도 생기니 앱의 퀄리티 업업~ 좋네용~ 데이터 바인딩을 사용하지 않은 이유만 설명해주시면 어푸 드릴게오~~~

private fun startShimmer(isLoading: Boolean) {
if (isLoading) {
binding.sflOfferingDetail.startShimmer()
binding.sflOfferingDetail.visibility = View.VISIBLE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

databinding을 사용하지 않은 이유가 따로 있는지 궁금함돠

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

따로 없습니둥..
databinding하도록 변경할게요!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵~~ 기다릴게오~

Copy link
Contributor

@chaehyuns chaehyuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생많으셨어요 서기씌~~~~

@chaehyuns chaehyuns merged commit f408214 into develop Oct 22, 2024
3 checks passed
@chaehyuns chaehyuns deleted the feature/544-offering-detail-skeleton-ui branch October 22, 2024 05:25
fromitive pushed a commit that referenced this pull request Nov 28, 2024
* build: skeleton-ui 의존성 추가

* feat: shimmer 레이아웃 작성

* feat: skeleton ui구현

* refactor: visibility를 여부 로직을 databinding으로 이동

* chore: git 충돌 해결

* Revert "refactor: visibility를 여부 로직을 databinding으로 이동"

This reverts commit 6b0ac9cdef917e28eb0ca4238a1eeba619e6eb81.

* refactor: visibility여부 로직을 databinding으로 이동
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ 공모 상세 페이지 진입 시 로딩이 된 후에 화면을 보여주도록 수정
3 participants