-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 공모 상세 페이지 진입 시 로딩이 된 후에 화면을 보여주도록 수정 #609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다 시머 좋네요 ㅎㅎ
// Skeleton-UI | ||
implementation(libs.shimmer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 시머~~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
시머도 생기니 앱의 퀄리티 업업~ 좋네용~ 데이터 바인딩을 사용하지 않은 이유만 설명해주시면 어푸 드릴게오~~~
private fun startShimmer(isLoading: Boolean) { | ||
if (isLoading) { | ||
binding.sflOfferingDetail.startShimmer() | ||
binding.sflOfferingDetail.visibility = View.VISIBLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
databinding을 사용하지 않은 이유가 따로 있는지 궁금함돠
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
따로 없습니둥..
databinding하도록 변경할게요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵~~ 기다릴게오~
This reverts commit 6b0ac9cdef917e28eb0ca4238a1eeba619e6eb81.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생많으셨어요 서기씌~~~~
* build: skeleton-ui 의존성 추가 * feat: shimmer 레이아웃 작성 * feat: skeleton ui구현 * refactor: visibility를 여부 로직을 databinding으로 이동 * chore: git 충돌 해결 * Revert "refactor: visibility를 여부 로직을 databinding으로 이동" This reverts commit 6b0ac9cdef917e28eb0ca4238a1eeba619e6eb81. * refactor: visibility여부 로직을 databinding으로 이동
📌 관련 이슈
close #544
✨ 작업 내용
// Skeleton-UI implementation(libs.shimmer)
📚 기타
Before
KakaoTalk_Video_2024-10-21-22-04-03.mp4
After
[deleay 3초]
KakaoTalk_Video_2024-10-21-22-05-02.mp4
[delay X]
KakaoTalk_Video_2024-10-21-22-05-32.mp4