Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] 편집 페이지에 들어갔을 때, 검증에 어긋나는 입력이 가능해지는 현상 해결한다. #911

Merged
merged 4 commits into from
Oct 24, 2024
Merged

[FE] 편집 페이지에 들어갔을 때, 검증에 어긋나는 입력이 가능해지는 현상 해결한다. #911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a81b34e
fix: detail 쿼리를 가져올 때 빈 내용의 null을 없애고가져온다
skiende74 Oct 24, 2024
00d19b0
chore: playwright CI 워커의 수를 4개로 한다
skiende74 Oct 24, 2024
aaf751f
Merge branch 'dev-fe' of https://github.com/woowacourse-teams/2024-ba…
skiende74 Oct 24, 2024
932ff56
feat: playwright firefox 해제
skiende74 Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions frontend/playwright.api.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default defineConfig({
/* Retry on CI only */
retries: process.env.CI ? 2 : 0,
/* Opt out of parallel tests on CI. */
workers: process.env.CI ? 1 : undefined,
workers: process.env.CI ? 4 : undefined,
/* Reporter to use. See https://playwright.dev/docs/test-reporters */
reporter: 'html',
/* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
Expand All @@ -41,11 +41,11 @@ export default defineConfig({
dependencies: ['setup'],
},

{
name: 'firefox',
use: { ...devices['Desktop Firefox'], storageState: 'playwright/.auth/user.json' },
dependencies: ['setup'],
},
// {
// name: 'firefox',
// use: { ...devices['Desktop Firefox'], storageState: 'playwright/.auth/user.json' },
// dependencies: ['setup'],
// },

{
name: 'webkit',
Expand Down
10 changes: 5 additions & 5 deletions frontend/playwright.mock.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default defineConfig({
/* Retry on CI only */
retries: process.env.CI ? 2 : 0,
/* Opt out of parallel tests on CI. */
workers: process.env.CI ? 1 : undefined,
workers: process.env.CI ? 4 : undefined,
/* Reporter to use. See https://playwright.dev/docs/test-reporters */
reporter: 'html',
/* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
Expand All @@ -38,10 +38,10 @@ export default defineConfig({
use: { ...devices['Desktop Chrome'] },
},

{
name: 'firefox',
use: { ...devices['Desktop Firefox'] },
},
// {
// name: 'firefox',
// use: { ...devices['Desktop Firefox'] },
// },

{
name: 'webkit',
Expand Down
5 changes: 3 additions & 2 deletions frontend/src/apis/checklist.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@ export const getChecklistAllQuestions = async () => {

export const getChecklistDetail = async (id: number) => {
const response = await fetcher.get({ url: BASE_URL + ENDPOINT.CHECKLIST_ID_V1(id) });
const data = await response.json();
return data as ChecklistInfo;
const data = (await response.json()) as ChecklistInfo;
data.room = Object.fromEntries(Object.entries(data.room).filter(([, value]) => value !== null));
return data;
};

export const getChecklists = async (isLikeFiltered: boolean = false) => {
Expand Down
Loading