[FE] UT피드백에 의한 편집 페이지 새로고침 로직 문제를 해결한다 #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skiende74
temporarily deployed
to
frontend-msw
GitHub Actions
Inactive
skiende74
changed the title
skiende74
temporarily deployed
to
frontend-msw
GitHub Actions
Inactive
…ng-ggood into feat/884-jade-fix-editpage-and-focus-and-default
skiende74
temporarily deployed
to
frontend-msw
GitHub Actions
Inactive
healim01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
(로직) 편집페이지 새로고침시 가까운역 안뜨던문제해결.
-> 방법 = 이 store도 로컬스토리지관리
(로직) 디폴트방이름 1번부터시작하게.
-> 방법 = 예시용체크리스트를 카운팅안하게해서 1번부터시작하게
(접근성) 방기본정보 인풋태그 포커스(탭)안되던 현상 해결
-> 원인 = 원래 되는게 맞는거라 원인확인해본결과 포커스트랩이 원인이였습니다.
모달이 켜져야 포커스트랩이 발동하도록되어있어야하는데 모달꺼져있을때도 포커스트랩이 켜져있어서 모달 오픈시만 포커스되도록 고쳐서해결했습니다.
(UI) 좋아요버튼 테두리현상 해결 :
-> 원인 = 탭인덱스. 헤일리와얘기해보고 탭인덱스 제거했습니다.
📢 논의하고 싶은 내용
리안 디테일페이지는 지하철역이슈없나요?
🎸 기타