Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

방 비교 결과 조회 API를 만든다. #100

Merged
merged 8 commits into from
Jul 25, 2024
Merged

방 비교 결과 조회 API를 만든다. #100

merged 8 commits into from
Jul 25, 2024

Conversation

JINU-CHANG
Copy link
Contributor

@JINU-CHANG JINU-CHANG commented Jul 25, 2024 •
edited
Loading

❗ Issue

✨ 구현한 기능

  • 체크리스트 간 비교
  • 카테고리 별 점수 계산

📢 논의하고 싶은 내용

🎸 기타

  • 점수 계산부분은 도메인으로 분리할 예정입니다.
  • 테스트 코드도 도메인으로 분리한 후 보완하겠습니다.
  • 시간이 부족해서 일단 기능 구현은 완료했는데 리팩토링이 많이 필요할 것 같습니다 .. 🥲

@JINU-CHANG JINU-CHANG added this to the 마일스톤 4주차 milestone Jul 25, 2024
shin-jisong
shin-jisong approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@shin-jisong shin-jisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO로 바꿀 부분을 표시해 두면 좀 더 리뷰가 수월할 것 같아요!
일단 시급 이슈로 승인합니다

tkdgur0906
tkdgur0906 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@tkdgur0906 tkdgur0906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리팩토링 후 다시 PR 보내주세요!
일단 머지하겠습니다!

@tkdgur0906 tkdgur0906 merged commit 32ee0d9 into dev-be Jul 25, 2024
1 check passed
@tkdgur0906 tkdgur0906 deleted the feat/94-checklist-comparison branch July 25, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shin-jisong shin-jisong shin-jisong approved these changes

@tkdgur0906 tkdgur0906 tkdgur0906 approved these changes

Assignees

@tsulocalize tsulocalize

@JINU-CHANG JINU-CHANG

Labels
🔒 BE 😊 Feature
Projects
None yet
Milestone
마일스톤 4주차
Development

Successfully merging this pull request may close these issues.
4 participants
@JINU-CHANG @tkdgur0906 @shin-jisong @tsulocalize