Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hong-sile
approved these changes
Jul 31, 2023
|
|
||
| @Bean | ||
| public RestTemplate restTemplate() { | ||
| return new RestTemplate(); |
There was a problem hiding this comment.
혹시 이렇게 별도로 분리한 이유가 있을까요?
| public class FcmMessage { | ||
|
|
||
| @JsonProperty("validate_only") | ||
| private final boolean validateOnly; |
There was a problem hiding this comment.
혹시 이게 무엇을 의미하는지 간략하게 알려주실 수 있나요?
| //when | ||
| final NotificationResponse expected = notificationCommandService.create(request); | ||
| final NotificationResponse expected = mockingNotificationCommandService.create(request); |
There was a problem hiding this comment.
지금 다시 보니까 expected랑 actual 이 바뀌어야 할 것 같아요.(어차피 모킹이라 큰 의미 없지만, 그래도...)
hyeonjerry
approved these changes
Jul 31, 2023
| @@ -28,6 +28,8 @@ public class GithubClient { | |||
| @Value("${github.url.profile}") | |||
| private String profileUrl; | |||
|
|
|||
| private final RestTemplate restTemplate; | |||
amaran-th
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
FCM에게 알람 요청 보내는 기능 구현
빨리 문서화해서 올리도록 할게요