fix: status로 필터링 시 발생하는 500 오류 해결 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- null 체크해서 해결 #130
hong-sile
reviewed
Jul 28, 2023
| if (cannotFoundKeyStatus(filteredEvents)) { | ||
| return List.of(); | ||
| } | ||
| return EventResponse.makeEventResponsesByStatus(status, filteredEvents); |
There was a problem hiding this comment.
이러한 null 체크해서 빈 리스트를 반환하는 로직이 생겨났으니 테스트도 추가해보는 것이 어떨까요?
|
기존에 테스트 코드를 많이 작성하셨음에도 불구하고 |
amaran-th
added
버그
hyeonjerry
approved these changes
Jul 29, 2023
| @@ -148,12 +147,19 @@ private List<EventResponse> filterEventResponsesByStatus(final String statusName | |||
| final EnumMap<EventStatus, List<Event>> sortAndGroupByEventStatus) { | |||
| if (isExistStatusName(statusName)) { | |||
| EventStatus status = EventStatus.from(statusName); | |||
| return EventResponse.makeEventResponsesByStatus(status, | |||
| sortAndGroupByEventStatus.get(status)); | |||
| List<Event> filteredEvents = sortAndGroupByEventStatus.get(status); | |||
There was a problem hiding this comment.
sortAndGroupByEventStatus라는게 저는 메서드 명처럼 느껴지는데 아마란스는 어떻게 생각하시나요?
There was a problem hiding this comment.
듣고 보니 그렇게 보이네요...! eventsForEventStatus로 변경했습니다😀
- sortAndGroupByStatus을 eventsForEventStatus로 변경 #130
hong-sile
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#130
📝작업 내용
예상 소요 시간 및 실제 소요 시간
급하게 작업하느라 측정하지 않았습니다...죄송합니다