Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom headers to be specified for all api requests #64

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

fatboystring
Copy link

Hi, thanks for the library. I have an issue where a third party woocommerce api I interact with implements caching, but I always need the most up-to-date version of the data when I call the api.

I am able to bust the cache using a custom query parameter with a timestamp but this feels hacky. The third party api does respect the cache-control header and it seems generally useful to be able to specify custom headers to send with every request.

I'm hoping you'd be open to merging and releasing the changes in this PR. Please do let me know if you would like me to make any further changes, happy to help.

Thanks in advance

@benje
Copy link

benje commented Aug 6, 2021

I also need this functionality and @fatboystring's solution looks great!

@HubertGL
Copy link

HubertGL commented Nov 5, 2022

this could also solve the problem with the X-HTTP-Method-Override header indirectly if http methods are limited to only GET and POST for security reasons. But this feature might be easier implemented as separated feature within the __request() method to only change the init method and not each put and delete for the clients

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants