Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Application Password" to "QIT Token" and other improvements #118

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

Luc45
Copy link
Member

@Luc45 Luc45 commented Jan 26, 2024

This PR aims to reduce authentication confusion by renaming application_password to qit_token.

Solves #108

It also does some other minor improvements, such as moving examples on how to run tests to AFTER authentication is complete.

It keeps the --application_password option for backwards compatibility for the time being.

Testing Instructions will be added in Docs repo.

@Luc45 Luc45 self-assigned this Jan 26, 2024
@Luc45 Luc45 requested a review from a team January 26, 2024 20:30
Copy link
Contributor

@zhongruige zhongruige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested great for me, thanks for these updates @Luc45!

@Luc45 Luc45 merged commit 268d20f into trunk Jan 29, 2024
1 check passed
@Luc45 Luc45 deleted the 24-01/rename-application-password branch January 29, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants