Merge pull request #156 from woocommerce/24-03/faster-phpcs

Port Fast PHPCS PR to CLI

Makefile

@@ -16,16 +16,16 @@ endif
 ## Run a command inside an alpine PHP 8 CLI image.
 ## 1. Command to execute, eg: "./vendor/bin/phpcs" 2. Working dir (optional)
 define execPhpAlpine
-    @docker image inspect qit-cli-php-xdebug > /dev/null 2>&1 || docker build --build-arg CI=${CI} -t qit-cli-php-xdebug ./_build/docker/php83
+    @docker image inspect qit-cli-php-xdebug-pcntl > /dev/null 2>&1 || docker build --build-arg CI=${CI} -t qit-cli-php-xdebug-pcntl ./_build/docker/php83
     docker run --rm \
         --user $(DOCKER_USER) \
         -v "${PWD}:/app" \
-        -v "${PWD}/_build/docker/php83/ini:/usr/local/etc/php/conf.d/" \
+        -v "${PWD}/_build/docker/php83/ini/xdebug.ini:/usr/local/etc/php/conf.d/xdebug.ini" \
         --env QIT_HOME=/tmp \
         --env PHP_IDE_CONFIG=serverName=qit_cli \
         --workdir "$(2:=/)" \
         --add-host host.docker.internal:host-gateway \
-        qit-cli-php-xdebug \
+        qit-cli-php-xdebug-pcntl \
         bash -c "php -d xdebug.start_with_request=$(if $(filter 1,$(DEBUG)),yes,no) -d memory_limit=1G $(1)"
 endef
 
@@ -56,6 +56,7 @@ phpcbf:
 	$(call execPhpAlpine,/app/src/vendor/bin/phpcbf /app/src/qit-cli.php /app/src/src -s --standard=/app/src/.phpcs.xml.dist)
 
 phpcs:
+	$(MAKE) phpcbf
 	$(call execPhpAlpine,/app/src/vendor/bin/phpcs /app/src/qit-cli.php /app/src/src -s --standard=/app/src/.phpcs.xml.dist)
 
 phpstan:

_build/docker/php83/Dockerfile

@@ -4,7 +4,10 @@ ARG CI
 
 RUN apt-get update \
      && apt-get install -y libzip-dev \
-     && docker-php-ext-install zip
+     && docker-php-ext-install zip \
+     && docker-php-ext-enable zip \
+     && docker-php-ext-install pcntl \
+     && docker-php-ext-enable pcntl
 
 # Install Xdebug only if not in CI environment
 RUN if [ "$CI" != "true" ]; then \

_build/docker/php83/ini/xdebug.ini

@@ -1,4 +1,3 @@
-zend_extension=xdebug.so
 xdebug.client_host = host.docker.internal
 xdebug.client_port = 9003
 xdebug.output_dir = /app/_build/docker/php83/xdebug/output

src/.phpcs.xml.dist

@@ -5,7 +5,7 @@
     <arg value="sp"/>
     <arg name="colors"/>
     <arg name="extensions" value="php"/>
-    <arg name="parallel" value="8"/>
+    <arg name="parallel" value="16"/>
 
     <config name="testVersion" value="7.2-"/>
     <rule ref="PHPCompatibility"/>