Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MinGW build #914

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix MinGW build #914

wants to merge 1 commit into from

Conversation

mncat77
Copy link

@mncat77 mncat77 commented Oct 20, 2024

@wolfpld: Just made changes to fix the build for now, should probably not be merged until it is tested properly - is there a standard procedure for that already?
Feel like the __except1 macro control flow also needs to be checked, seems a bit iffy.

@mncat77 mncat77 marked this pull request as draft October 20, 2024 14:27
@wolfpld
Copy link
Owner

wolfpld commented Oct 20, 2024

should probably not be merged until it is tested properly - is there a standard procedure for that already?

There is nothing formalized for that.

@mncat77
Copy link
Author

mncat77 commented Oct 20, 2024

should probably not be merged until it is tested properly - is there a standard procedure for that already?

There is nothing formalized for that.

Alright, will see if I can find more time to test this properly, should probably not be merged until it is tested properly by someone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants