Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kserve-modelmesh/0.12.0-r5: cve remediation #38111

Merged

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 21, 2024

Copy link
Contributor Author

octo-sts bot commented Dec 21, 2024

Gen AI suggestions to solve the build error:

• Detected Error: ```
[ERROR] Failed to execute goal on project model-mesh: Could not resolve dependencies for project com.ibm.watson:model-mesh:jar:0.4.2-SNAPSHOT
[ERROR] dependency: ch.qos.logback:logback-core:jar:1.15.13 (import)
[ERROR] Could not find artifact ch.qos.logback:logback-core:jar:1.15.13 in central (https://repo.maven.apache.org/maven2)


• Error Category: Dependency

• Failure Point: Maven dependency resolution during build

• Root Cause Analysis: The specified version of logback-core (1.15.13) does not exist in Maven Central. The latest stable version is 1.4.14.

• Suggested Fix:
1. Update or override the logback dependency version in the pipeline:
```yaml
  - uses: maven/pombump
    with:
      replacements:
        - search: '<logback.version>1.15.13</logback.version>'
          replace: '<logback.version>1.4.14</logback.version>'

• Explanation: The build is failing because it's trying to fetch a non-existent version of logback-core. The fix updates the dependency to the latest stable version available in Maven Central.

• Additional Notes:

  • Logback versions follow semantic versioning (major.minor.patch)
  • Version 1.15.13 appears to be invalid as the minor version 15 does not exist
  • The latest stable version 1.4.14 includes security fixes and is recommended

• References:

Copy link
Contributor Author

octo-sts bot commented Dec 25, 2024

Gen AI suggestions to solve the build error:

• Detected Error: Build appears to be hanging during the Maven dependency download phase, specifically at:
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/io/grpc/grpc-netty/1.60.2/grpc-netty-1.60.2.pom

• Error Category: Dependency/Network

• Failure Point: Maven dependency resolution for io.grpc:grpc-netty:1.60.2

• Root Cause Analysis:
The build appears to be timing out or hanging while trying to download dependencies from Maven Central. This could be due to network connectivity issues, repository availability, or proxy configuration problems.

• Suggested Fix:

  1. Add repository mirrors to the pom.xml:
<mirrors>
    <mirror>
        <id>google-maven-central</id>
        <name>Google Maven Central</name>
        <url>https://maven-central.storage-download.googleapis.com/repos/central/data/</url>
        <mirrorOf>central</mirrorOf>
    </mirror>
</mirrors>
  1. Add a timeout configuration to the melange.yaml:
environment:
  contents:
    packages:
      - build-base
      - busybox
      - maven-3.9
      - openjdk-17
  options:
    MAVEN_OPTS: "-Dmaven.wagon.http.timeout=60 -Dmaven.wagon.http.pool=false"

• Explanation:
Adding alternate Maven mirrors and timeout configurations can help resolve dependency download issues by:

  1. Providing alternative download sources
  2. Preventing hanging on slow connections
  3. Ensuring proper timeout handling

• Additional Notes:

  • The Google Maven mirror is often more reliable for CI environments
  • Consider caching dependencies if builds are frequent
  • Monitor Maven Central status if issues persist

• References:

@hbh7 hbh7 self-assigned this Jan 9, 2025

This comment was marked as resolved.

@octo-sts octo-sts bot added ai/skip-comment Stop AI from commenting on PR bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. labels Jan 9, 2025
@hbh7 hbh7 requested a review from a team January 9, 2025 19:39
@kbsteere kbsteere force-pushed the cve-kserve-modelmesh-0cddae655cfc1161a944783ff221d658 branch 2 times, most recently from e712984 to 6591b88 Compare January 9, 2025 21:04
@kbsteere
Copy link
Contributor

kbsteere commented Jan 9, 2025

Should just need to add

- groupId: ch.qos.logback
   artifactId: logback-classic
   version: 1.3.15
 - groupId: ch.qos.logback
   artifactId: logback-core
   version: 1.3.15
 - groupId: org.slf4j
   artifactId: slf4j-api
   version: 2.0.16

to the pombump-deps.yaml

@kbsteere kbsteere merged commit 5fa107e into main Jan 9, 2025
16 checks passed
@kbsteere kbsteere deleted the cve-kserve-modelmesh-0cddae655cfc1161a944783ff221d658 branch January 9, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. GHSA-pr98-23f8-jwxv kserve-modelmesh/0.12.0-r5 manual/review-needed maven/pombump request-cve-remediation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants