Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(libxml2): move more docs to docs package #31708

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

shyim
Copy link
Contributor

@shyim shyim commented Oct 23, 2024

Make the image smaller by removing docs

Fixes: shyim/wolfi-php#519

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)
  • If non-streamed package names no longer built, open PR to withdraw them (see WITHDRAWING PACKAGES)

For package updates (renames) in the base images

When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)

  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build
  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages
  • Upon launch, does apk upgrade --latest successfully upgrades packages or performs no actions

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

ajayk
ajayk previously approved these changes Oct 23, 2024
@ajayk
Copy link
Contributor

ajayk commented Oct 23, 2024

@shyim needs linting fixes

@shyim
Copy link
Contributor Author

shyim commented Oct 24, 2024

@ajayk fixed

@shyim
Copy link
Contributor Author

shyim commented Oct 24, 2024

@ajayk I can switch the clone to https://github.com/GNOME/libxml2 . wdym?

@ajayk ajayk enabled auto-merge (squash) October 24, 2024 18:05
@ajayk ajayk merged commit bc9ca9a into wolfi-dev:main Oct 24, 2024
11 checks passed
@shyim shyim deleted the remove-libxml2-docs branch October 24, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove more files from the image
2 participants