Fix/data centric monitoring #57
Conversation
…ing page with data-centric approach
…t 'metadata' containing both dataset ID and topic + style: improve look of station editor and other pages
… by creating helper function that creates a list of topics
… list is saved correctly
…-code' in password fields
package-lock.json
Outdated
| @@ -30,7 +30,7 @@ | |||
| "vue-router": "^4.0.0", | |||
| "vue-tel-input": "^8.3.1", | |||
| "vue3-apexcharts": "^1.4.4", | |||
| "vuetify": "^3.4.0", | |||
| "vuetify": "^3.7.0", | |||
| <TopicHierarchySelector :value="topicSelected" @update:modelValue="newValue => topicSelected = newValue"/> | ||
| </v-card-item> | ||
| <v-card-title>Select dataset identifier</v-card-title> | ||
| <v-col cols="12"> |
There was a problem hiding this comment.
should the selector be wrapped in a v-card-rext?
There was a problem hiding this comment.
No, re-using v-card-text for every component, instead of just plain text, is often bad practice because the component very easily overflows. We should be using the Vuetify grid system as much as possible to accurately position components. I'm not going to change every instance of this, only the situations where I found the aforementioned cutoffs.
| return { | ||
| id: feature.properties.identifier, | ||
| topic: feature.properties['wmo:topicHierarchy'], | ||
| metadata: { |
There was a problem hiding this comment.
Accidental residual from a previous idea, which was to have this component re-usable as both a data ID selector and topic selector. This ended up unnecessarily complicated for the time constraints.
|
|
||
| const fetchOptions = async () => { | ||
| // Get dataset IDs | ||
| if (testMode) { |
There was a problem hiding this comment.
I really dislike like, is there not a better way? At a minimum can we not have static json files rather than embedding the test data in the code?
There was a problem hiding this comment.
This can be addressed in the future
| @@ -82,7 +82,7 @@ | |||
| </v-card-text> | |||
| <v-container> | |||
| <v-text-field label="wis2box auth token for 'processes/wis2box'" v-model="token" rows="1" | |||
| :append-icon="showToken ? 'mdi-eye' : 'mdi-eye-off'" :type="showToken ? 'text' : 'password'" | |||
| :append-icon="showToken ? 'mdi-eye' : 'mdi-eye-off'" :type="showToken ? 'text' : 'password'" autocomplete="one-time-code" | |||
There was a problem hiding this comment.
There is an issue with Chrome attempting to autofill components based on its type being password. @maaikelimper has experienced various glitches thanks to Chrome's insistence. There's no official way to disable autofill, the closest we have found is this HTML tag autocomplete, which when set to one-time-code should make Chrome see it as a fresh password (like the OTP used in 2FA) and thus no autofill.
| @@ -390,7 +390,7 @@ | |||
| </v-card-title> | |||
| <v-card-text> | |||
| <v-text-field label="wis2box auth token for 'processes/wis2box'" v-model="token" rows="1" | |||
| :append-icon="showToken ? 'mdi-eye' : 'mdi-eye-off'" :type="showToken ? 'text' : 'password'" | |||
| :append-icon="showToken ? 'mdi-eye' : 'mdi-eye-off'" :type="showToken ? 'text' : 'password'" autocomplete="one-time-code" | |||
No description provided.