Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marine templates #54

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Marine templates #54

merged 4 commits into from
Aug 15, 2024

Conversation

david-i-berry
Copy link
Member

Addition of WCMP2 metadata templates for drifters and ship based surface weather observations.

Update of synop and temp to reference codes.wmo.int for Earth system discipline rather than github.
@tomkralidis
Copy link
Collaborator

@david-i-berry could we have used the MCF format here for the template? This would ensure / increase compatibility between various workflows in wis2box.

@tomkralidis tomkralidis self-requested a review August 8, 2024 11:14
@maaikelimper
Copy link
Collaborator

maaikelimper commented Aug 14, 2024

@david-i-berry I have deployed this on the test-server, see https://wis2box-test.wis2dev.io/wis2box-webapp/dataset_editor, the label for ship-hourly-template is incorrect leading to duplicate labels in the dropdown:
image

@tomkralidis
Copy link
Collaborator

@maaikelimper can you the links as published via MinIO (which is what is sent to WIS2 proper)? I am also seeing that, in both examples, properties.themes[0].scheme is an array of one string, which instead should be a string, so:

        "themes": [
            {   
                "concepts": [
                    {   
                        "id": "weather",
                        "title": "Weather"
                    }   
                ],  
                "scheme": "http://codes.wmo.int/wis/topic-hierarchy/earth-system-discipline"
            }   
        ],  

@maaikelimper
Copy link
Collaborator

Here are the public href links are requested:
https://wis2box-test.wis2dev.io/data/metadata/urn:wmo:md:io-wis2dev-test2:core.surface-based-observations.ship-hourly.json
https://wis2box-test.wis2dev.io/data/metadata/urn:wmo:md:io-wis2dev-test2:core.surface-based-observations.drifting-buoys.PROGRAM.json

Please note that the problem you reported, about the scheme needing to be a string not an array, is unrelated to this PR, the same can be seen for other datasets using the existing synop template:
https://wis2box-test.wis2dev.io/data/metadata/urn:wmo:md:io-wis2dev-test2:surface-based-observations.synop.json

@tomkralidis
Copy link
Collaborator

Thanks. I've opened wmo-im/wis2box#728 to track the WCMP2 encoding fix.

@tomkralidis tomkralidis merged commit b15ec23 into main Aug 15, 2024
2 checks passed
@tomkralidis tomkralidis deleted the marine-templates branch August 15, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants