Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python versions #132

Closed
wants to merge 10 commits into from
Closed

Python versions #132

wants to merge 10 commits into from

Conversation

david-i-berry
Copy link
Member

Removal of end of life (or soon to be ) python versions from the tests.yml
Removal of numpy from requirements (installed by eccodes)

@david-i-berry david-i-berry marked this pull request as draft February 15, 2024 09:43
@david-i-berry david-i-berry marked this pull request as ready for review February 15, 2024 09:46
@@ -7,11 +7,11 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.7, 3.8, 3.9]
python-version: ["3.9", "3.10", "3.11", "3.12"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep 3.8?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we specifically need 3.8? It will be end of life later this year.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone on focal, 3.8 is required. We can remove a few months following 3.8 EOL.

@david-i-berry david-i-berry marked this pull request as draft February 16, 2024 13:45
@david-i-berry
Copy link
Member Author

Changes now included in thread bug fix branch. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants