Merge pull request #72 from wjdp/feature/http-ua

Set HTTP User-Agent
wjdp · Jan 28, 2018 · 59e5286 · 59e5286
2 parents 26f20eb + 45f720a
commit 59e5286
Show file tree

Hide file tree

Showing 36 changed files with 166,492 additions and 212 deletions.
diff --git a/htmltest/check-link.go b/htmltest/check-link.go
@@ -148,7 +148,10 @@ func (hT *HTMLTest) checkExternal(ref *htmldoc.Reference) {
 		// to panic if err != nil.
 		output.CheckErrorPanic(err)
 
-		// Set headers
+		// Set UA header
+		req.Header.Set("User-Agent", "htmltest/" + hT.opts.Version)
+
+		// Set headers from HTTPHeaders option
 		for key, value := range hT.opts.HTTPHeaders {
 			// Due to the way we're loading in config these keys and values are interface{}. In normal cases they are
 			// strings, but could very easily be ints (side note: this isn't great, we'll fix this later, #73)

diff --git a/htmltest/fixtures/vcr/generic/citeBroken.html.cassette b/htmltest/fixtures/vcr/generic/citeBroken.html.cassette
diff --git a/htmltest/fixtures/vcr/generic/citeValid.html.cassette b/htmltest/fixtures/vcr/generic/citeValid.html.cassette
diff --git a/htmltest/fixtures/vcr/generic/videoBroken.html.cassette b/htmltest/fixtures/vcr/generic/videoBroken.html.cassette
@@ -155,6 +155,178 @@
       },
       "ErrType": "*net.OpError",
       "ErrMsg": "dial tcp: lookup swowkopskpok.com on 127.0.1.1:53: no such host"
+    },
+    {
+      "Request": {
+        "Method": "GET",
+        "URL": {
+          "Scheme": "http",
+          "Opaque": "",
+          "User": null,
+          "Host": "nope.yyz",
+          "Path": "/vid.mp4",
+          "RawPath": "",
+          "ForceQuery": false,
+          "RawQuery": "",
+          "Fragment": ""
+        },
+        "Header": {
+          "Accept": [
+            "*/*"
+          ],
+          "Range": [
+            "bytes=0-0"
+          ],
+          "User-Agent": [
+            "htmltest/"
+          ]
+        },
+        "Body": ""
+      },
+      "Response": {
+        "Status": "",
+        "StatusCode": 0,
+        "Proto": "",
+        "ProtoMajor": 0,
+        "ProtoMinor": 0,
+        "Header": null,
+        "Body": null,
+        "ContentLength": 0,
+        "TransferEncoding": null,
+        "Trailer": null,
+        "TLS": null
+      },
+      "ErrType": "*net.OpError",
+      "ErrMsg": "dial tcp: lookup nope.yyz on 127.0.1.1:53: no such host"
+    },
+    {
+      "Request": {
+        "Method": "GET",
+        "URL": {
+          "Scheme": "https",
+          "Opaque": "",
+          "User": null,
+          "Host": "swowkopskpok.com",
+          "Path": "/xyz.ogg",
+          "RawPath": "",
+          "ForceQuery": false,
+          "RawQuery": "",
+          "Fragment": ""
+        },
+        "Header": {
+          "Accept": [
+            "*/*"
+          ],
+          "Range": [
+            "bytes=0-0"
+          ],
+          "User-Agent": [
+            "htmltest/"
+          ]
+        },
+        "Body": ""
+      },
+      "Response": {
+        "Status": "",
+        "StatusCode": 0,
+        "Proto": "",
+        "ProtoMajor": 0,
+        "ProtoMinor": 0,
+        "Header": null,
+        "Body": null,
+        "ContentLength": 0,
+        "TransferEncoding": null,
+        "Trailer": null,
+        "TLS": null
+      },
+      "ErrType": "*net.OpError",
+      "ErrMsg": "dial tcp: lookup swowkopskpok.com on 127.0.1.1:53: no such host"
+    },
+    {
+      "Request": {
+        "Method": "GET",
+        "URL": {
+          "Scheme": "http",
+          "Opaque": "",
+          "User": null,
+          "Host": "nope.yyz",
+          "Path": "/vid.mp4",
+          "RawPath": "",
+          "ForceQuery": false,
+          "RawQuery": "",
+          "Fragment": ""
+        },
+        "Header": {
+          "Accept": [
+            "*/*"
+          ],
+          "Range": [
+            "bytes=0-0"
+          ],
+          "User-Agent": [
+            "htmltest/dev"
+          ]
+        },
+        "Body": ""
+      },
+      "Response": {
+        "Status": "",
+        "StatusCode": 0,
+        "Proto": "",
+        "ProtoMajor": 0,
+        "ProtoMinor": 0,
+        "Header": null,
+        "Body": null,
+        "ContentLength": 0,
+        "TransferEncoding": null,
+        "Trailer": null,
+        "TLS": null
+      },
+      "ErrType": "*net.OpError",
+      "ErrMsg": "dial tcp: lookup nope.yyz on 127.0.1.1:53: no such host"
+    },
+    {
+      "Request": {
+        "Method": "GET",
+        "URL": {
+          "Scheme": "https",
+          "Opaque": "",
+          "User": null,
+          "Host": "swowkopskpok.com",
+          "Path": "/xyz.ogg",
+          "RawPath": "",
+          "ForceQuery": false,
+          "RawQuery": "",
+          "Fragment": ""
+        },
+        "Header": {
+          "Accept": [
+            "*/*"
+          ],
+          "Range": [
+            "bytes=0-0"
+          ],
+          "User-Agent": [
+            "htmltest/dev"
+          ]
+        },
+        "Body": ""
+      },
+      "Response": {
+        "Status": "",
+        "StatusCode": 0,
+        "Proto": "",
+        "ProtoMajor": 0,
+        "ProtoMinor": 0,
+        "Header": null,
+        "Body": null,
+        "ContentLength": 0,
+        "TransferEncoding": null,
+        "Trailer": null,
+        "TLS": null
+      },
+      "ErrType": "*net.OpError",
+      "ErrMsg": "dial tcp: lookup swowkopskpok.com on 127.0.1.1:53: no such host"
     }
   ]
 }