Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta Release #468

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Beta Release #468

merged 4 commits into from
Aug 2, 2024

Conversation

JamsRepos
Copy link
Contributor

No description provided.

@wizarr-sentry wizarr-sentry bot requested review from MrDynamo and a user August 1, 2024 11:52
@JamsRepos
Copy link
Contributor Author

@albinmedoc A few people in Discord are asking for edit functionality of the pre-existing pages? What do you reckon?

@albinmedoc
Copy link
Contributor

albinmedoc commented Aug 1, 2024

@albinmedoc A few people in Discord are asking for edit functionality of the pre-existing pages? What do you reckon?

These pages are conditional depending on whether you have Plex/Jellyfin and Discord.
It would be possible to edit these by putting them in a separate database table and have them prepopulated with the English hardcoded version (how they look today).

What we lose with this implementation is multilingualism. Onboarding pages can only be in one language at a time.

I think this still sounds like a very good idea.

Give me a GO and I'll start development

@JamsRepos
Copy link
Contributor Author

@albinmedoc A few people in Discord are asking for edit functionality of the pre-existing pages? What do you reckon?

These pages are conditional depending on whether you have Plex/Jellyfin and Discord. It would be possible to edit these by putting them in a separate database table and have them prepopulated with the English hardcoded version (how they look today).

What we lose with this implementation is multilingualism. Onboarding pages can only be in one language at a time.

I think this still sounds like a very good idea.

Give me a GO and I'll start development

Feel free! Free reign, I think the language for the instance will be the same for the whole server regardless. So the content would be written in the language of the admin no doubt.

What Wizarr is made for is for easy management of your friends and family, the only issue you'd have with multi-language support is if you ran a big share or something of the sorts, which we don't want to openly support. So for the most part, the language across the server will be the same.

I think you're absolutely fine to crack on, I don't see no issues. 😀

* fix: 🐛 Solve some issues with markdown preview

* fix: 🩹 Change background color of code block

* fix: 🐛 Change background color of markdown editor
@JamsRepos
Copy link
Contributor Author

@albinmedoc did you want me to merge this PR in now to get these bugs out on the beta or did you want me to wait for the onboarding amends?

@albinmedoc
Copy link
Contributor

Go ahead and merge this to beta.

I'm having a little trouble getting all the onboarding pages editable. Not sure how long it will take.

@JamsRepos JamsRepos merged commit 32e4ba1 into beta Aug 2, 2024
10 checks passed
@wizarr-sentry
Copy link
Contributor

wizarr-sentry bot commented Dec 15, 2024

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants