Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PG-621] - fix play button disappears from video #1283

Closed
wants to merge 155 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
155 commits
Select commit Hold shift + click to select a range
ef9eb36
V4 README.
nirnaor Dec 15, 2022
ac1ee85
Handling different base branch.
nirnaor Dec 15, 2022
6b42a1b
new log message.
nirnaor Dec 15, 2022
94ee4ca
Changed log message (#1023)
nirnaor Dec 20, 2022
7ac6efc
using correct env variable.
nirnaor Dec 20, 2022
156815f
v4.1.83
invalid-email-address Dec 20, 2022
709bcf6
adding stable dist tag
nirnaor Dec 20, 2022
bec1f5a
increase threshhold for blueprints.
nirnaor Dec 20, 2022
7e708a5
add hotfixes readme
nirnaor Dec 20, 2022
6804e66
v4.1.84
invalid-email-address Dec 20, 2022
f34eedc
changed log message (#1024)
nirnaor Dec 21, 2022
7695cef
v4.1.85
invalid-email-address Dec 21, 2022
2c2c759
Revert "refactor new sps in the gallery package (#985)"
yhattav Jan 1, 2023
50580b1
Revert "Revert "refactor new sps in the gallery package (#985)""
yhattav Jan 1, 2023
e987d68
v4.1.86
invalid-email-address Jan 1, 2023
c871e37
revert new option convention changes (#1030)
IzaacAyelin Jan 1, 2023
64c2312
v4.1.87
invalid-email-address Jan 1, 2023
34c7200
move onclick to item container (#1040)
liatv Jan 8, 2023
e806d6a
v4.1.88
invalid-email-address Jan 8, 2023
7b1615a
remove BEST HOTFIX EVER console log (#1042)
liatv Jan 8, 2023
b30f210
v4.1.89
invalid-email-address Jan 8, 2023
acbbf85
transform instead of margin (#1046)
yhattav Jan 12, 2023
bd8fe24
v4.1.90
invalid-email-address Jan 12, 2023
e706c63
Revert "move onclick to item container (#1040)" (#1051)
IzaacAyelin Jan 15, 2023
514c8e8
v4.1.91
invalid-email-address Jan 15, 2023
d6fee3f
add key up to item container
liatv Jan 17, 2023
c78724a
v4.1.92
invalid-email-address Jan 17, 2023
ff55026
fix gallery horizontal get more items in rtl (#1057)
yhattav Jan 18, 2023
ab67c5e
v4.1.93
invalid-email-address Jan 18, 2023
e925a95
fix rtl transform animation (#1063)
yhattav Jan 19, 2023
86b95f0
v4.1.94
invalid-email-address Jan 19, 2023
0ff3b39
test (#1078)
liatv Jan 24, 2023
2277647
v4.1.95
invalid-email-address Jan 24, 2023
2dcf2c8
add onKeyUp to item continer div - it's wahts triggers a tag on enter…
liatv Feb 1, 2023
8cc7e3e
v4.1.96
invalid-email-address Feb 1, 2023
a98f3fe
refacror scrollLess loop animations (Deck and Fade) to have class tra…
liatv Feb 14, 2023
1d77a9b
v4.1.97
invalid-email-address Feb 14, 2023
1501eb9
V4 fix scroll less loop bug (#1105)
liatv Feb 14, 2023
0865974
v4.1.98
invalid-email-address Feb 14, 2023
1b42118
add bind this to isCurrentVideoStillVisible (#1116)
liatv Mar 12, 2023
50fc261
v4.1.99
invalid-email-address Mar 12, 2023
2cef5cd
start fixibg scroll isVisible (#1121)
liatv Mar 15, 2023
a6a0357
v4.1.100
invalid-email-address Mar 15, 2023
1adecb0
fix custom components (#1118)
yhattav Mar 15, 2023
bf28944
v4.1.101
invalid-email-address Mar 15, 2023
b6f35a3
use the custom image renderer in video placeholder (#1124)
yhattav Apr 4, 2023
c586e83
v4.1.102
invalid-email-address Apr 4, 2023
59245ca
none loading mode (#1126)
yhattav Apr 18, 2023
9b886d7
v4.1.103
invalid-email-address Apr 18, 2023
a1c00cf
fix scrollBase issues in blueprints
yhattav May 22, 2023
b6bde89
fix scrollBase issues in blueprints (#1129)
yhattav May 22, 2023
4aaa02e
v4.1.104
invalid-email-address May 22, 2023
deb213f
fix typo
yhattav May 23, 2023
52d6da3
Merge branch 'fix_scrollBase_issues' into V4_Final
yhattav May 23, 2023
c90ae2a
v4.1.105
invalid-email-address May 23, 2023
65b99b9
fix schema checks (#1151)
noam-heller1 Jul 27, 2023
161da13
v4.1.106
invalid-email-address Jul 27, 2023
b57a392
[SEO alt text]fix alt text fallback (#1150)
noam-heller1 Aug 1, 2023
98c3640
v4.1.107
invalid-email-address Aug 1, 2023
5c46ba5
Remove unused css/classname (#1157)
IzaacAyelin Aug 20, 2023
5b0b1fe
v4.1.108
invalid-email-address Aug 20, 2023
747da2f
[gallery + lib] improve: use partial window mock on hydrate (#1161)
IzaacAyelin Aug 29, 2023
6c55d10
v4.1.109
invalid-email-address Aug 29, 2023
ba79cf4
fix thumbnail onClick navigation RTL (#1166)
liatv Oct 2, 2023
21c838e
v4.1.110
invalid-email-address Oct 2, 2023
a01112a
Fix tumbnail item click rtl v4 new (#1167)
liatv Oct 3, 2023
781acbf
v4.1.111
invalid-email-address Oct 3, 2023
daddb07
[FIX_V4] - fix scrollIndication hydration exception (#1181)
liatv Jan 28, 2024
10663e2
v4.1.112
invalid-email-address Jan 28, 2024
1897db9
Quick fix is prerender changes (#1182)
yhattav Feb 11, 2024
cca870e
v4.1.113
invalid-email-address Feb 11, 2024
0543840
setTimeout 0 onArrowClick (#1191)
liatv Feb 21, 2024
9efbd2c
v4.1.114
invalid-email-address Feb 21, 2024
2abed7b
deffer click events and mobile hover (#1190)
IzaacAyelin Feb 25, 2024
5f62dc7
v4.1.115
invalid-email-address Feb 25, 2024
46aed7b
INP next arrow interaction fix (#1193)
liatv Feb 28, 2024
3c57c53
v4.1.116
invalid-email-address Feb 28, 2024
8e0b133
change GalleryContainer file to contain only explisit import (#1196)
liatv Mar 7, 2024
a131b29
v4.1.117
invalid-email-address Mar 7, 2024
e73f35c
revert remove_default_export_from_GalleryContainer (#1197)
liatv Mar 12, 2024
9df09b4
make videoItem use esm import (#1198)
liatv Mar 12, 2024
5b5b2b2
use sass instead of not supported node-sass (#1199)
liatv Mar 12, 2024
a0dabe4
v4.1.118
invalid-email-address Mar 12, 2024
9bd3bfe
[A11y] - Switching image using the Enter key
Galpittel Mar 14, 2024
693fac0
v4.1.119
invalid-email-address Mar 14, 2024
e6ac1a2
Renaming ENTER_KEY const
Galpittel Mar 14, 2024
c457ba1
v4.1.120
invalid-email-address Mar 14, 2024
1f0257a
hack for video item (#1205)
frontned Mar 27, 2024
5b13125
v4.1.121
invalid-email-address Mar 27, 2024
ba89fc3
verify horizontalElement when scrolling horizontal (#1206)
liatv Apr 1, 2024
56273a6
v4.1.122
invalid-email-address Apr 1, 2024
ed8f457
add keys in image renderer (#1209)
IzaacAyelin Apr 17, 2024
08dad94
v4.1.123
invalid-email-address Apr 17, 2024
61a50a8
Revert "hack for video item" (#1210)
liatv Apr 21, 2024
2eb461b
v4.1.124
invalid-email-address Apr 21, 2024
2a6f6ce
trigger hover when without overlay and no action ON MOBILE (#1213)
liatv Apr 25, 2024
1b7e53a
v4.1.125
invalid-email-address Apr 25, 2024
8b4b318
fix inline style react errors (#1214)
IzaacAyelin Apr 25, 2024
f8ee7ea
v4.1.126
invalid-email-address Apr 25, 2024
214bb3e
use another proxy to bind functions to the window (#1217)
IzaacAyelin Apr 30, 2024
8c4b9f3
v4.1.127
invalid-email-address Apr 30, 2024
ed95abf
fix videoPlay access (#1220)
liatv Apr 30, 2024
9409521
v4.1.128
invalid-email-address Apr 30, 2024
b7ed3bd
fix timeout in ON_CLICK event (#1221)
liatv Apr 30, 2024
37de714
v4.1.129
invalid-email-address Apr 30, 2024
660488e
ensure onload is called (#1223)
IzaacAyelin May 1, 2024
ca0a22b
v4.1.130
invalid-email-address May 1, 2024
93a2af3
fix play button hydrate issue and dynamic import(#1225)
IzaacAyelin May 2, 2024
33d23b4
v4.1.131
invalid-email-address May 2, 2024
6f74da0
cache custom props on window object (#1228)
IzaacAyelin May 9, 2024
009fa67
v4.1.132
invalid-email-address May 9, 2024
15675ac
check scrollY in getVisibleItems (#1230)
IzaacAyelin May 12, 2024
411a7bf
v4.1.133
invalid-email-address May 12, 2024
7b10352
define heigher hls quality start level (#1233)
IzaacAyelin May 16, 2024
b02d935
v4.1.134
invalid-email-address May 16, 2024
f847463
add id to image renderer (#1235)
IzaacAyelin May 16, 2024
ab04ca6
v4.1.135
invalid-email-address May 16, 2024
6b1e53c
change hls options (#1237)
IzaacAyelin May 19, 2024
0b186c0
v4.1.136
invalid-email-address May 19, 2024
7875da5
prevent scroll event before interaction (#1236)
IzaacAyelin May 19, 2024
61d8e18
v4.1.137
invalid-email-address May 19, 2024
3a482e7
TEST Interaction for mobile (#1239)
noam-heller1 May 26, 2024
3600d2e
v4.1.138
invalid-email-address May 26, 2024
b3b9e36
Revert "TEST Interaction for mobile (#1239)" (#1240)
noam-heller1 May 26, 2024
dd8b1d6
v4.1.139
invalid-email-address May 26, 2024
cc37648
fix thumbnails duplication (#1241)
IzaacAyelin May 28, 2024
15ab325
v4.1.140
invalid-email-address May 28, 2024
c0c626b
extend force video youtube link (#1244)
liatv May 29, 2024
fa02bb1
v4.1.141
invalid-email-address May 29, 2024
b54d83d
[blueprints] fix: items changed check in blueprints (#1248)
IzaacAyelin Jun 13, 2024
b3cecde
v4.1.142
invalid-email-address Jun 13, 2024
c94002e
Fix invalid aria role v4 (#1250)
Galpittel Jun 18, 2024
9de5082
v4.1.143
invalid-email-address Jun 18, 2024
417ee94
PG-592: Adding focus ring prop to control non-interactive focusable e…
hadasze Jun 26, 2024
f37164d
v4.1.144
invalid-email-address Jun 26, 2024
fb10502
[gallery] fix: video rendering placeholder (#1260)
IzaacAyelin Jul 9, 2024
a217b15
v4.1.145
invalid-email-address Jul 9, 2024
900e047
change invalid activeIndex when the number of items in the gallery is…
Galpittel Jul 11, 2024
3f44d0c
v4.1.146
invalid-email-address Jul 11, 2024
841a788
Ensure the correct video player is loaded (#1262)
noam-heller1 Jul 25, 2024
3d36562
v4.1.147
invalid-email-address Jul 25, 2024
06427b4
Revert "Ensure the correct video player is loaded (#1262)" (#1263)
noam-heller1 Jul 25, 2024
c85b21f
v4.1.148
invalid-email-address Jul 25, 2024
59f9011
Hls import in componentWillMount (#1264)
noam-heller1 Jul 28, 2024
e1db85f
v4.1.149
invalid-email-address Jul 28, 2024
69643f3
Revert "change invalid activeIndex when the number of items in the ga…
noam-heller1 Jul 31, 2024
5ba2950
v4.1.150
invalid-email-address Jul 31, 2024
959dd12
change invalid activeIndex when filtering items (#1268)
Galpittel Aug 4, 2024
36a38f0
v4.1.151
invalid-email-address Aug 4, 2024
2d0aeed
get correct galleryStructure to calculate gallery width (#1269)
Galpittel Aug 5, 2024
afd5a87
v4.1.152
invalid-email-address Aug 5, 2024
ab128f4
Bug fix - Show all relevant thumbnails (#1272)
Galpittel Aug 15, 2024
d037360
update deps and node version and fix tests config (#1282)
IzaacAyelin Aug 20, 2024
e386e66
v4.1.153
invalid-email-address Aug 20, 2024
a5672d5
show video play button in placeholder depends only on show button toggle
hadasze Aug 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
16 changes: 8 additions & 8 deletions .github/workflows/node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,16 @@ name: Test

on:
push:
branches: [ master ]
branches: [ master, V4_Final ]
pull_request:
branches: [ master ]
branches: [ master, V4_Final ]

jobs:
lint:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.13.0]
node-version: [16.20.0]
steps:
- uses: actions/checkout@v2
- name: Install and run lint
Expand All @@ -28,7 +28,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.13.0]
node-version: [16.20.0]
test-script: ["ci:test-unit", "ci:test-e2e-layouts","ci:test-e2e-styleParams", "ci:test-e2e-integration"]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
steps:
Expand All @@ -51,7 +51,7 @@ jobs:
needs: [lint, tests]
strategy:
matrix:
node-version: [16.13.0]
node-version: [16.20.0]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
steps:
- uses: actions/checkout@v2
Expand All @@ -75,8 +75,8 @@ jobs:
if: github.event_name == 'push'
# run: echo "this is a push to master"
run: |
git checkout master
lerna publish patch --exact --yes --registry https://registry.npmjs.org
git checkout ${{ github.ref_name }}
lerna publish patch --exact --yes --dist-tag stable --registry https://registry.npmjs.org
npm run changelog
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Expand All @@ -92,7 +92,7 @@ jobs:
needs: [lint, tests]
strategy:
matrix:
node-version: [16.13.0]
node-version: [16.20.0]
steps:
- uses: actions/checkout@v2
- name: update-playground
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.13.0
16.20.0
19 changes: 19 additions & 0 deletions HOTFIXES.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
We now support two different products with two different open source versions:
TPA: V4
Native: V5

In order to release a hot fix to TPA:
1. `git checkout V4_Final`
2. `git checkout -b V4_FINAL_MY_COOL_HOTFIX`
3. write your code
4. `git push origin -u V4_FINAL_MY_COOL_HOTFIX`
5. Create a pull request using GitHub, and *SET THE BRANCH THE BASE BRANCH TO V4_FINAL*
6. Wait for tests to pass
7. Merge to V4_FINAL


After merge to V4_FINAL
1. V4 branch will deploy a new patch upon successfull build
2. Once V4_FINAL has a successfull build, you will see the new version as a seperate commit
3. Use loki/other tools to update the TPA with the new version

1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Blazing fast & beautiful galleries built with React. [Try it out now.](https://p
[![NPM Version](https://img.shields.io/npm/v/pro-gallery.svg?style=flat)](https://www.npmjs.com/package/pro-gallery)
[![Build Status](https://travis-ci.org/wix/pro-gallery.svg?branch=master)](https://travis-ci.com/wix/pro-gallery)

This is V4 hotfix branch

## Gettings Started
The best way to get started is by using the [Playground](https://pro-gallery.surge.sh). Use the sidebar to configure the gallery layout you need. When you're done, click the `Generate Gallery Code` button to get the copy-paste-ready code.
Expand Down
4 changes: 2 additions & 2 deletions lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"packages": [
"packages/*"
],
"version": "4.1.82"
}
"version": "4.1.153"
}
Loading
Loading