(chore): fix-all-the-things #2497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drcpu-github
force-pushed
the
fix-all-the-things
branch
3 times, most recently
from
fc9c143
to
d8d9f7c
Compare
guidiaz
reviewed
Oct 31, 2024
guidiaz
requested changes
Oct 31, 2024
| let _ = stakes.reset_age( | ||
| *liar_pkh, | ||
| Capability::Witnessing, | ||
| block_epoch + 10, |
There was a problem hiding this comment.
Any particular reason for resetting the coin_age to -10 instead of just 0 ?
There was a problem hiding this comment.
I felt it was a bit weird to reset a liar only to 0 given that we also do that for an (honest) committer (albeit at the commit stage), but I don't have a strong opinion on it.
aesedepece
force-pushed
the
2.0-master
branch
from
52bccd3
to
daa66db
Compare
guidiaz
requested changes
Oct 31, 2024
drcpu-github
force-pushed
the
fix-all-the-things
branch
3 times, most recently
from
2e4bfd2
to
480467d
Compare
drcpu-github
force-pushed
the
fix-all-the-things
branch
2 times, most recently
from
68330ac
to
22f0ea5
Compare
1) Reserve collateral for a validator when it commits to solving a data request 2) Remove tally transaction outputs for data request participant 3) Correctly reward data request solvers and slash out of consensus revealers
…commit transaction under wit/2
…rotocol version 1.8
…300M WIT has been staked
…s.*_wit2 for clarity
…cluded in blocks prior to V1_8 / V2_0 respectively
…nt the pool overflowing
…en sent from the CLI
…re included in a consolidated block
ProtocolVersion::V1_8 activation is set at 10000 as to not interfere with other tests.
drcpu-github
force-pushed
the
fix-all-the-things
branch
2 times, most recently
from
4924e0f
to
7b5bed1
Compare
drcpu-github
force-pushed
the
fix-all-the-things
branch
3 times, most recently
from
5f4edd2
to
2f44ae7
Compare
|
This is now in master ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.