Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(Rad): Include retrievals' response time within RadonReports #2414

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feat(Rad): Include retrievals' response time within RadonReports #2414

wants to merge 1 commit into from

Conversation

guidiaz
Copy link
Contributor

@guidiaz guidiaz commented Dec 13, 2023

No description provided.

@guidiaz guidiaz force-pushed the feat/rad/running-time branch 2 times, most recently from 155c669 to a21afd1 Compare February 23, 2024 11:48
@guidiaz guidiaz changed the base branch from 2.0-base to master February 23, 2024 11:48
aesedepece
aesedepece requested changes Feb 23, 2024
View reviewed changes
Copy link
Member

@aesedepece aesedepece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small comment on code style.

rad/src/lib.rs Show resolved Hide resolved
aesedepece
aesedepece approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@aesedepece aesedepece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Please fixup the latest commit into the original one, an we're ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aesedepece aesedepece aesedepece approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guidiaz @aesedepece