Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[from-gatsby] use LinkCard for community resources #10781

Merged
merged 2 commits into from
Jan 24, 2025
Merged

[from-gatsby] use LinkCard for community resources #10781

merged 2 commits into from
Jan 24, 2025

Conversation

sarah11918
Copy link
Member

@sarah11918 sarah11918 commented Jan 23, 2025 •
edited
Loading

This PR changes the bulleted list of community resources to <LinkCard> components in a <CardGrid> for the Migrate from Gatsby page.

If we like this, then we can accept PRs to update the other Migrate to Astro pages!

Note:

  • Titles are the blog post / article titles
  • Descriptions are the subtitle / description of the article if available. If not, I chose the earliest sentence(s) that seemed like a standalone subtitle/tagline/intro. So, we have some flexibility here (e.g. being more strategic about length).

Before:
image

After:
Screenshot 2025-01-23 18 55 47

@netlify Netlify
Copy link

netlify bot commented Jan 23, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 2ca54b7
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6792de12addc960008e7545d
😎 Deploy Preview https://deploy-preview-10781--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jan 23, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/migrate-to-astro/from-gatsby.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

TheOtterlord
TheOtterlord approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

delucis
delucis approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@sarah11918 sarah11918 added Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! community resource Adds a link to an external community resource, such as a recipe, tutorial or talk. consistency/formatting Standardizing without changing docs content e.g. indenting, lists etc. labels Jan 24, 2025
@sarah11918 sarah11918 merged commit b0d45d0 into main Jan 24, 2025
10 checks passed
@sarah11918 sarah11918 deleted the sarah-gatsby branch January 24, 2025 00:49
@jsparkdev jsparkdev mentioned this pull request Jan 24, 2025
Merged
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Jan 24, 2025
@ArmandPhilippot
i18n(fr): update migrate-to-astro/from-gatsby.mdx
2dcd64f 
See withastro#10781 and withastro#10793
@ArmandPhilippot ArmandPhilippot mentioned this pull request Jan 24, 2025
Merged
thomasbnt added a commit that referenced this pull request Jan 24, 2025
@ArmandPhilippot @thomasbnt
i18n(fr): update migrate-to-astro/from-gatsby.mdx (#10795)
d80527c 
* i18n(fr): update `migrate-to-astro/from-gatsby.mdx`

See #10781 and #10793

* remove the duplicated list...

---------

Co-authored-by: Thomas Bonnet <[email protected]>
@Nin3lee Nin3lee mentioned this pull request Jan 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheOtterlord TheOtterlord TheOtterlord approved these changes

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
community resource Adds a link to an external community resource, such as a recipe, tutorial or talk. consistency/formatting Standardizing without changing docs content e.g. indenting, lists etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarah11918 @astrobot-houston @delucis @TheOtterlord