-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(zh-cn): Add on-demand-rendering.mdx
#10736
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
哈喽 MonchiLin!欢迎你加入简中文档翻译的团队,感谢你对这篇 on-demand-rendering.mdx
文档翻译投入的时间和精力。
我在建议中标注了几处需要修改的部分,多数是关于链接锚点的,可以在查看后应用修改。另外我还注意到和源文档不同的一处标点(位于第 99 行的:
),以及一处主动添加代码注释的文本(位于第 248 行的 body
),因为我觉得利于阅读所以我选择保留了。
@Nin3lee 非常感谢你的审核和指正, 之前确实不了解锚点的转换规则 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💜 Thanks again for your effort and time to contribute.
Maybe other maintainers will have their own suggestions.
感谢你的翻译。被 review 的修改建议,需要点击 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里还有一点修改。还有上面 @Nin3lee Review 的
Co-authored-by: Nin3 <[email protected]>
Co-authored-by: Nin3 <[email protected]>
Co-authored-by: Nin3 <[email protected]>
Co-authored-by: Nin3 <[email protected]>
Co-authored-by: Nin3 <[email protected]>
Co-authored-by: liruifengv <[email protected]>
Co-authored-by: liruifengv <[email protected]>
Co-authored-by: liruifengv <[email protected]>
Co-authored-by: liruifengv <[email protected]>
:) 感谢, 已修改 |
@MonchiLin 这里有三处 broken links,因为其他页面引用了这个页面的链接,需要同步更新一下 |
:) 已同步修改 |
@liruifengv 已修复, 感谢你的耐心 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you! @MonchiLin and Thanks @Nin3lee for review. Welcome to Team Docs!
Add
src/content/docs/zh-cn/guides/on-demand-rendering.mdx