Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(zh-cn): Add on-demand-rendering.mdx #10736

Merged
merged 15 commits into from
Jan 23, 2025
Merged

Conversation

MonchiLin
Copy link
Contributor

Add src/content/docs/zh-cn/guides/on-demand-rendering.mdx

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jan 21, 2025
Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 21651b2
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6791a6a6af698f0008097116
😎 Deploy Preview https://deploy-preview-10736--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jan 21, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
zh-cn/guides/astro-db.mdx Localization changed, will be marked as complete.
zh-cn/guides/on-demand-rendering.mdx Localization added, will be marked as complete.
zh-cn/reference/integrations-reference.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor

@Nin3lee Nin3lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哈喽 MonchiLin!欢迎你加入简中文档翻译的团队,感谢你对这篇 on-demand-rendering.mdx 文档翻译投入的时间和精力。

我在建议中标注了几处需要修改的部分,多数是关于链接锚点的,可以在查看后应用修改。另外我还注意到和源文档不同的一处标点(位于第 99 行的),以及一处主动添加代码注释的文本(位于第 248 行的 body),因为我觉得利于阅读所以我选择保留了。

src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated Show resolved Hide resolved
@MonchiLin
Copy link
Contributor Author

@Nin3lee 非常感谢你的审核和指正, 之前确实不了解锚点的转换规则

Copy link
Contributor

@Nin3lee Nin3lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💜 Thanks again for your effort and time to contribute.

Maybe other maintainers will have their own suggestions.

@liruifengv
Copy link
Member

感谢你的翻译。被 review 的修改建议,需要点击 commit suggestion 才行,或者在本地修改完提交。修改完成之后再点击 resolve@MonchiLin

Copy link
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里还有一点修改。还有上面 @Nin3lee Review 的

src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated Show resolved Hide resolved
src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated Show resolved Hide resolved
@MonchiLin
Copy link
Contributor Author

这里还有一点修改。还有上面 @Nin3lee Review 的

:) 感谢, 已修改

@liruifengv
Copy link
Member

image

@MonchiLin 这里有三处 broken links,因为其他页面引用了这个页面的链接,需要同步更新一下

@MonchiLin
Copy link
Contributor Author

image

@MonchiLin 这里有三处 broken links,因为其他页面引用了这个页面的链接,需要同步更新一下

:) 已同步修改

@MonchiLin
Copy link
Contributor Author

@liruifengv 已修复, 感谢你的耐心 :)

Copy link
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! @MonchiLin and Thanks @Nin3lee for review. Welcome to Team Docs!

@liruifengv liruifengv merged commit 19c4552 into withastro:main Jan 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants