-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update v5.mdx #10731
Update v5.mdx #10731
Conversation
Add more explicit instructions about replacing `slug` by `id`
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Add clearer instructions. Co-authored-by: Armand Philippot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience and help in improving the docs, LGTM! Welcome to Team Docs! 🎉
I'm just adding one last commit to add backticks around a function.
See #10731 Co-authored-by: Thomas Bonnet <[email protected]>
Add more explicit instructions about replacing
slug
byid
Description (required)
For non-English speakers like me, the instructions given didn't seem explicit enough. I spent a couple of hours before I realized that I also had to rename the files.
Related issues & labels (optional)