Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v5.mdx #10731

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Update v5.mdx #10731

merged 5 commits into from
Jan 23, 2025

Conversation

severindupouy
Copy link
Contributor

Add more explicit instructions about replacing slug by id

Description (required)

For non-English speakers like me, the instructions given didn't seem explicit enough. I spent a couple of hours before I realized that I also had to rename the files.

Related issues & labels (optional)

  • Suggested label: improve or update documentation

Add more explicit instructions about replacing `slug` by `id`
Copy link

netlify bot commented Jan 19, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2a39083
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6792c2a859c2b40008295d96
😎 Deploy Preview https://deploy-preview-10731--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jan 19, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/upgrade-to/v5.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Add clearer instructions.

Co-authored-by: Armand Philippot <[email protected]>
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience and help in improving the docs, LGTM! Welcome to Team Docs! 🎉
I'm just adding one last commit to add backticks around a function.

src/content/docs/en/guides/upgrade-to/v5.mdx Outdated Show resolved Hide resolved
@ArmandPhilippot ArmandPhilippot added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Jan 23, 2025
@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jan 23, 2025
@ArmandPhilippot ArmandPhilippot merged commit b5d67dc into withastro:main Jan 23, 2025
10 checks passed
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Jan 24, 2025
thomasbnt added a commit that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants