fix: update two code snippets in the tutorial #10727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use `any` before to avoid a Typescript error but it is missing in the Code Check-In. So if someone decide to replace their code with the one suggested in Code Check-In they'll get a Typescript error.
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Jan 21, 2025
Signed-off-by: Thomas Bonnet <[email protected]>
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Jan 21, 2025
Signed-off-by: Thomas Bonnet <[email protected]>
thomasbnt
added a commit
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
I followed the tutorial again to check the consistency between the tutorial and the
blog-tutorial-demorepository (see withastro/blog-tutorial-demo#39 and withastro/blog-tutorial-demo#40). Almost everything looks good here, I only updated two things:anyin the code check-in of unit 5-3 to prevent a Typescript error (if someone tries to replace his code) and to match what we had before.Related issues & labels (optional)