Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve heading id slug format #12972

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: improve heading id slug format #12972

wants to merge 3 commits into from
+81 −6

Conversation

jurajkapsz
Copy link
Contributor

Changes

  • Fixes nbsp spaces missing in heading slug values #12970
  • Makes slug value account for NBSP spaces as spaces
  • Cleans up slugified ID value to be in kebab-case
  • Potentially changes so far generated ID values, eg. from -my---heading-text-- to my-heading-text

Testing

  • Added unit tests on slug formatting. Hope they are up to par.
  • Also tested manually.

Docs

No docs change needed.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 7229c39

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the feat: markdown Related to Markdown (scope) label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feat: markdown Related to Markdown (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nbsp spaces missing in heading slug values
1 participant
@jurajkapsz