Rainbow Declensions! 🌈 #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the final column in the table is color rather than reflexive This change maintains existing behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(please follow this guide) 📝📐
(try
lein ring server) 👩💻🚀Fixes Issue: #95
Hey!
So I saw that there is another open PR for this issue which looks good, but since it's incomplete I thought I'd have a go. I also noticed that in that solution another
.cssfile is created which contains classes for all the pronouns. This is fine but means having two "sources of truth" so I thought having the color for the pronoun in the table would fix this.I've set the first three pronouns to have colors and left the rest black, but if you want me to leave them all black for now I can do that. Also I've left the links to the pronouns on the landing page and the 'all' list as their default link colors, but I don't think it would be very difficult to implement it for them too so I can do that in a subsequent PR or whatever.
The app boots fine and all the tests pass, and I've added some tests for the new stuff too.
I really love this project and I hope this is useful!
Thanks!
Also, disclaimer, I'm not very good at Clojure (in fact this is my first time doing anything real with it) so sorry in advance if there's anything I could have done better. I'm super happy to make changes.
Images