Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GitHub Actions matrix to support the Python version range #442

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Fix GitHub Actions matrix to support the Python version range #442

merged 2 commits into from
Jan 27, 2025

Conversation

kvid
Copy link
Collaborator

@kvid kvid commented Jan 16, 2025 •
edited
Loading

  • Fix GitHub Actions fixed by PR #408 are still failing #441
  • Use ubuntu-latest for the supported Python versions
    • Use ubuntu-22.04 only for Python 3.7-3.8
  • Update setup.py with all tested python versions
  • Required actions for the dev branch seems to work as intended with these new actions.
  • Required actions for the master branch should later also work as intended by cherry-picking the first commit from dev to master.
    • The second commit updating setup.py should wait until just before the next release.
    • A rebase-merge is needed to keep these two commits separate.
  • I suggest removing support of any Python EOL versions in a separate issue.

@kvid kvid linked an issue Jan 16, 2025 that may be closed by this pull request
GitHub Actions fixed by PR #408 are still failing #441
Open
@kvid kvid force-pushed the python_versions_matrix branch from 40981af to 74baa2d Compare January 16, 2025 19:12
kvid added 2 commits January 20, 2025 18:20
@kvid kvid force-pushed the python_versions_matrix branch from 74baa2d to 971e6c0 Compare January 20, 2025 17:28
@kvid kvid requested a review from amotl January 25, 2025 01:50
amotl
amotl approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@amotl amotl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 👍

@kvid kvid merged commit 7cf9244 into wireviz:dev Jan 27, 2025
6 checks passed
kvid added a commit that referenced this pull request Jan 27, 2025
@kvid
Use ubuntu-latest for the supported Python versions (#442)
6c87c27 
Use ubuntu-22.04 only for Python 3.7-3.8
by including them separately into the matrix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotl amotl amotl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub Actions fixed by PR #408 are still failing
2 participants
@kvid @amotl