fix: Conversations and Profile Views are reported individually (WPB-14942) #3792

ohassine · 2025-01-09T14:30:25Z

WPB-14942 [Android] Conversations and Profile Views are reported individually

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Views for conversations are reported to Countly with a unique conversation ID attached to them: Conversation(eed94f9*)
For some screen we report to countly SomeOther with screen name as route: SomeOther(route=other_user_profile_screen)

Solutions

Check if current screen is SomeOther then we send the route otherwise we send class name

Needs releases with:

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…ted-individually

codecov-commenter · 2025-01-09T15:15:47Z

Codecov Report

Attention: Patch coverage is 9.09091% with 20 lines in your changes missing coverage. Please review.

Project coverage is 45.75%. Comparing base (92baa59) to head (bc28aec).

Files with missing lines	Patch %	Lines
...tlin/com/wire/android/util/CurrentScreenManager.kt	9.09%	20 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3792      +/-   ##
===========================================
- Coverage    45.79%   45.75%   -0.05%     
===========================================
  Files          486      486              
  Lines        16632    16647      +15     
  Branches      2792     2799       +7     
===========================================
  Hits          7617     7617              
- Misses        8234     8249      +15     
  Partials       781      781

Files with missing lines	Coverage Δ
...tlin/com/wire/android/util/CurrentScreenManager.kt	`27.17% <9.09%> (-5.30%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92baa59...bc28aec. Read the comment docs.

github-actions · 2025-01-09T15:22:03Z

Built wire-android-staging-compat-pr-3792.apk is available for download

github-actions · 2025-01-09T15:22:11Z

Built wire-android-dev-debug-pr-3792.apk is available for download

…are-reported-individually' into Conversations-and-Profile-Views-are-reported-individually

…ted-individually

github-actions · 2025-01-09T16:59:23Z

Built wire-android-staging-compat-pr-3792.apk is available for download

app/src/main/kotlin/com/wire/android/util/CurrentScreenManager.kt

github-actions · 2025-01-09T16:59:29Z

Built wire-android-dev-debug-pr-3792.apk is available for download

…are-reported-individually' into Conversations-and-Profile-Views-are-reported-individually

github-actions · 2025-01-10T09:02:31Z

Built wire-android-staging-compat-pr-3792.apk is available for download

github-actions · 2025-01-10T09:02:37Z

Built wire-android-dev-debug-pr-3792.apk is available for download

app/src/main/kotlin/com/wire/android/util/CurrentScreenManager.kt

yamilmedina

Looking good, left a question/concern and also to add, for this to work we need to remove this flag

wire-android/core/analytics-enabled/src/main/kotlin/com/wire/android/feature/analytics/AnonymousAnalyticsManagerImpl.kt

Line 46 in a59ff2e

internal var VIEW_TRACKING_ENABLED: Boolean = false

app/src/main/kotlin/com/wire/android/util/CurrentScreenManager.kt

ohassine · 2025-01-10T13:25:19Z

Looking good, left a question/concern and also to add, for this to work we need to remove this flag

wire-android/core/analytics-enabled/src/main/kotlin/com/wire/android/feature/analytics/AnonymousAnalyticsManagerImpl.kt

Line 46 in a59ff2e

internal var VIEW_TRACKING_ENABLED: Boolean = false

Yes, we still don't need it yet.

github-actions · 2025-01-10T14:02:26Z

Built wire-android-staging-compat-pr-3792.apk is available for download

github-actions · 2025-01-10T14:02:36Z

Built wire-android-dev-debug-pr-3792.apk is available for download

app/src/main/kotlin/com/wire/android/util/CurrentScreenManager.kt

github-actions · 2025-01-10T18:32:24Z

Built wire-android-staging-compat-pr-3792.apk is available for download

github-actions · 2025-01-10T18:32:31Z

Built wire-android-dev-debug-pr-3792.apk is available for download

app/src/main/kotlin/com/wire/android/util/CurrentScreenManager.kt

…ted-individually

github-actions · 2025-01-20T12:45:44Z

Built wire-android-staging-compat-pr-3792.apk is available for download

github-actions · 2025-01-20T12:45:51Z

Built wire-android-dev-debug-pr-3792.apk is available for download

MohamadJaara · 2025-01-20T13:30:31Z

...-enabled/src/main/kotlin/com/wire/android/feature/analytics/AnonymousAnalyticsManagerImpl.kt

@@ -182,7 +182,7 @@ object AnonymousAnalyticsManagerImpl : AnonymousAnalyticsManager {
        coroutineScope.launch {
            mutex.withLock {
                if (!isAnonymousUsageDataEnabled) return@withLock
-                anonymousAnalyticsRecorder?.recordView(screen)
+                anonymousAnalyticsRecorder?.recordView(screen.convertToCamelCase())


is it really needed to convert this to camel case for countly ?
i mean is the screen names defined there or we can define them as we need on android ?

it's for consistency, so we have clean data on the board. Otherwise some screen names are snake_case and some others are in camelCase.

…ted-individually

sonarqubecloud · 2025-01-22T09:31:47Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-01-22T10:23:55Z

Built wire-android-staging-compat-pr-3792.apk is available for download

github-actions · 2025-01-22T10:24:10Z

Built wire-android-dev-debug-pr-3792.apk is available for download

fix: Conversations and Profile Views are reported individually

e3f9399

pull-request-size bot added the size/XS label Jan 9, 2025

echoes-hq bot added the echoes/initiative: product-metrics-in-countly Analytics and KPIs label Jan 9, 2025

ohassine requested review from a team, typfel, sbakhtiarov, MohamadJaara, saleniuk and mathias-niboulies and removed request for a team January 9, 2025 14:30

github-actions bot assigned ohassine Jan 9, 2025

ohassine added 2 commits January 9, 2025 15:32

fix: cleanup

b702518

Merge branch 'develop' into Conversations-and-Profile-Views-are-repor…

fc04254

…ted-individually

ohassine added 3 commits January 9, 2025 16:41

fix: disable view tracking

860fd15

Merge remote-tracking branch 'origin/Conversations-and-Profile-Views-…

aa0bce5

…are-reported-individually' into Conversations-and-Profile-Views-are-reported-individually

Merge branch 'develop' into Conversations-and-Profile-Views-are-repor…

56e2cc2

…ted-individually

sbakhtiarov reviewed Jan 9, 2025

View reviewed changes

app/src/main/kotlin/com/wire/android/util/CurrentScreenManager.kt Outdated Show resolved Hide resolved

sbakhtiarov approved these changes Jan 9, 2025

View reviewed changes

ohassine added 2 commits January 10, 2025 09:22

fix: address comment

d4dfca8

Merge remote-tracking branch 'origin/Conversations-and-Profile-Views-…

d478e6c

…are-reported-individually' into Conversations-and-Profile-Views-are-reported-individually

MohamadJaara reviewed Jan 10, 2025

View reviewed changes

app/src/main/kotlin/com/wire/android/util/CurrentScreenManager.kt Outdated Show resolved Hide resolved

yamilmedina reviewed Jan 10, 2025

View reviewed changes

app/src/main/kotlin/com/wire/android/util/CurrentScreenManager.kt Outdated Show resolved Hide resolved

fix: address comment

262e37f

pull-request-size bot added size/S and removed size/XS labels Jan 10, 2025

MohamadJaara requested changes Jan 10, 2025

View reviewed changes

app/src/main/kotlin/com/wire/android/util/CurrentScreenManager.kt Outdated Show resolved Hide resolved

fix: use base route

10694ae

ohassine requested a review from yamilmedina January 10, 2025 17:55

ohassine requested a review from MohamadJaara January 13, 2025 09:42

saleniuk reviewed Jan 14, 2025

View reviewed changes

app/src/main/kotlin/com/wire/android/util/CurrentScreenManager.kt Outdated Show resolved Hide resolved

ohassine added 2 commits January 20, 2025 12:46

fix: address comment

f66bdb0

chore: cleanup

b979835

ohassine requested a review from saleniuk January 20, 2025 11:56

chore: cleanup NoConsecutiveBlankLines

d2b9c43

borichellow approved these changes Jan 20, 2025

View reviewed changes

Merge branch 'develop' into Conversations-and-Profile-Views-are-repor…

8d194e8

…ted-individually

ohassine enabled auto-merge January 20, 2025 12:02

MohamadJaara reviewed Jan 20, 2025

View reviewed changes

ohassine requested a review from MohamadJaara January 22, 2025 09:28

Merge branch 'develop' into Conversations-and-Profile-Views-are-repor…

bc28aec

…ted-individually

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Conversations and Profile Views are reported individually (WPB-14942) #3792

fix: Conversations and Profile Views are reported individually (WPB-14942) #3792

ohassine commented Jan 9, 2025 •

edited

Loading

codecov-commenter commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

yamilmedina left a comment

ohassine commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 20, 2025

github-actions bot commented Jan 20, 2025

MohamadJaara Jan 20, 2025

ohassine Jan 22, 2025 •

edited

Loading

sonarqubecloud bot commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

fix: Conversations and Profile Views are reported individually (WPB-14942) #3792

Are you sure you want to change the base?

fix: Conversations and Profile Views are reported individually (WPB-14942) #3792

Conversation

ohassine commented Jan 9, 2025 • edited Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Solutions

Testing

Test Coverage (Optional)

How to Test

Notes (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

codecov-commenter commented Jan 9, 2025 • edited Loading

Codecov Report

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

yamilmedina left a comment

Choose a reason for hiding this comment

ohassine commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 20, 2025

github-actions bot commented Jan 20, 2025

MohamadJaara Jan 20, 2025

Choose a reason for hiding this comment

ohassine Jan 22, 2025 • edited Loading

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 22, 2025

Quality Gate passed

github-actions bot commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

ohassine commented Jan 9, 2025 •

edited

Loading

codecov-commenter commented Jan 9, 2025 •

edited

Loading

ohassine Jan 22, 2025 •

edited

Loading